dd-firmware

firmware

Clone Tools

Stats

Commits this week: 22
Total Committers: 17
Last Commit: 28 May
Commits this week: 22

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 mins ago

Sean Nash

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

2 mins ago

Sean Nash

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

47 mins ago

Vinayakam Mani

Missing comment.

Missing comment.

49 mins ago

Vinayakam Mani

update comment. next one as well.

update comment. next one as well.

50 mins ago

Vinayakam Mani

blank line after the banner and maintain alphabetical order of include files.

blank line after the banner and maintain alphabetical order of include files.

3 hrs ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
3 hrs ago

Vinayakam Mani

Done.

Done.

4 hrs ago

Vendor - TEL - Jashwant Gantyada

4 hrs ago

Vendor - TEL - Jashwant Gantyada

I think we also need this to be uncommented, as we were running into an alarm because of this.

I think we also need this to be uncommented, as we were running into an alarm because of this.

5 hrs ago

Vinayakam Mani

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

5 hrs ago

Vinayakam Mani

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

5 hrs ago

Vinayakam Mani

as discussed, these were outcome of the test results. we will review these gains with latest controller.

as discussed, these were outcome of the test results. we will review these gains with latest controller.

5 hrs ago

Vinayakam Mani

Done.

Done.

5 hrs ago

Vinayakam Mani

Done.

Done.

Thursday 28 May
1:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
1:38 pm

Sean Nash

LDT-3975: Added distinct s/w fault IDs for PID controller faults.

Options
    • -0
    • +5
    ./App/Services/AlarmMgmtSWFaults.h
Wednesday 27 May
4:24 pm

Dara Navaei

3:43 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h
3:43 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -0
    • +16
    ./App/Modes/ModeUpdate.c
    • -0
    • +16
    ./App/Modes/ModeUpdate.h
    • -2
    • +2
    ./App/Modes/OperationModes.c
    • -2
    • +2
    ./App/Services/AlarmMgmtSWFaults.h
    • -2
    • +2
    ./App/Services/Messaging.c
    • -2
    • +2
    ./App/Services/Messaging.h
    • -2
    • +2
    ./App/Services/SystemCommDD.c
    • -2
    • +2
    ./App/Services/SystemCommDD.h
3:38 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

2:46 pm

Sean Nash

On DD f/w side, this should just be a simple pump controller. States should be Off and On (control to commanded Qsub). There is no flow sensor for feedback control, so assuming this is open loop si...

On DD f/w side, this should just be a simple pump controller. States should be Off and On (control to commanded Qsub). There is no flow sensor for feedback control, so assuming this is open loop similar to UF pump.
GenDialysate mode will have an HDF sub-state that signals this controller from Off to On and would also call separate controller for heater and separate (Switches) monitor for door sensors.

With all of that in mind, I think this unit should have a simpler name like SubPump.

2:39 pm

Sean Nash

I think there should be some state monitoring for potential alarm(s) in here too. Similar to BP door on TD f/w side where the current mode/state can signal this unit that it expects specific switch...

I think there should be some state monitoring for potential alarm(s) in here too. Similar to BP door on TD f/w side where the current mode/state can signal this unit that it expects specific switch state(s) (e.g. while in HDF state, we would expect the cap to be open and stowed and we would want to alarm if that was not the case).

2:36 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:33 pm

Dara Navaei

LDT-3272 addressed the code review comments

Options
    • -1
    • +1
    ./App/Services/Messaging.c
    • -16
    • +0
    ./App/Services/SystemCommDD.h
    • -16
    • +16
    ./DD.dil
    • -10
    • +10
    ./source/can.c
2:31 pm

Sean Nash

Where is call to HDF controller?

Where is call to HDF controller?

2:31 pm

Sean Nash

Monitors should come before mode mgmt above.

Monitors should come before mode mgmt above.

2:30 pm

Sean Nash

What about HemoDiaFiltration.h?

What about HemoDiaFiltration.h?

2:29 pm

Sean Nash

What about initHDF?

What about initHDF?

2:28 pm

Sean Nash

Where is HemoDiaFiltration.h?

Where is HemoDiaFiltration.h?

2:24 pm

Sean Nash

Why does this file name have pound signs pre/post?

Why does this file name have pound signs pre/post?