leahi-common

AlarmDefs.h

Clone Tools

Stats

Commits this week: 10
Total Committers: 17
Last Commit: 09 Jul
Commits this week: 10

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
7 hrs ago

Sean Nash

Remove

Remove

7 hrs ago

Sean Nash

Alphabetize these includes.

Alphabetize these includes.

7 hrs ago

Sean Nash

Why is this commented out?

Why is this commented out?

7 hrs ago

Sean Nash

Don't need yet.

Don't need yet.

7 hrs ago

Sean Nash

Remove all cleaning related functions.

Remove all cleaning related functions.

7 hrs ago

Sean Nash

Don't need this yet.

Don't need this yet.

7 hrs ago

Sean Nash

Remove for now.

Remove for now.

7 hrs ago

Sean Nash

Missing a comment.

Missing a comment.

7 hrs ago

Sean Nash

Remove last 5 messages.

Remove last 5 messages.

7 hrs ago

Sean Nash

Remove these. These are Denali modes.

Remove these. These are Denali modes.

7 hrs ago

Sean Nash

Remove these for now.

Remove these for now.

7 hrs ago

Sean Nash

Should use GENERIC_CONFIRMATION_REQUEST_T which already exists in OperationModes.h. This should be removed.

Should use GENERIC_CONFIRMATION_REQUEST_T which already exists in OperationModes.h. This should be removed.

7 hrs ago

Sean Nash

Put this back.

Put this back.

7 hrs ago

Sean Nash

Need to put if condition back.

Need to put if condition back.

7 hrs ago

Sean Nash

This check was correct before.

This check was correct before.

7 hrs ago

Sean Nash

This doesn't look like a command - it looks like a status.

This doesn't look like a command - it looks like a status.

9 hrs ago

Vendor - TEL - Suresh Dharnala

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before en...

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before entering Pre-Treatment.

Wednesday 15 Jul
3:03 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-TD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
9:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
Tuesday 14 Jul
11:17 pm

Sean Nash

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmatio...

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmation msg is received.

11:10 pm

Sean Nash

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

5:53 pm

Sean Nash

171

171

5:04 pm

Sean Nash

Is this too early to tell DD to start? Ask Vinay.

Is this too early to tell DD to start? Ask Vinay.

5:01 pm

Sean Nash

Initialize post treatment too.

Initialize post treatment too.

5:01 pm

Sean Nash

Delete this. No treatment params mode in Leahi.

Delete this. No treatment params mode in Leahi.

5:00 pm

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

4:58 pm

Sean Nash

I would keep this stuff commented out until disinfection is implemented.

I would keep this stuff commented out until disinfection is implemented.

4:55 pm

Sean Nash

Door already not required. Remove.

Door already not required. Remove.

4:54 pm

Sean Nash

break into 2 lines.

break into 2 lines.

4:52 pm

Sean Nash

Let's comment remaining states for now.

Let's comment remaining states for now.