td-firmware / firmware / App / Modes

ModeInitPOST.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 4
Last Commit: 28 May
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 hrs ago

Sean Nash

So then no need to initialize it here too. Remove " = FALSE".

So then no need to initialize it here too. Remove " = FALSE".

Wednesday 22 Jul
9:28 pm

Vendor - TEL - Suresh Dharnala

I agree but it is already in the init function.

I agree but it is already in the init function.

11:32 am

Sean Nash

Swap order of == for these 2 if statements - put constant on left side.

Swap order of == for these 2 if statements - put constant on left side.

11:19 am

Sean Nash

Why?

Why?

11:16 am

Sean Nash

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

11:14 am

Sean Nash

Use ternary operator to explicitly set to TRUE or FALSE.

Use ternary operator to explicitly set to TRUE or FALSE.

9:31 am

Sean Nash

Our TODO comments are all CAPs.

Our TODO comments are all CAPs.

9:25 am

Sean Nash

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

9:21 am

Sean Nash

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

9:19 am

Sean Nash

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

9:18 am

Sean Nash

Should return a BOOL (that is what ModeStandby is expecting).

Should return a BOOL (that is what ModeStandby is expecting).

9:18 am

Sean Nash

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

9:16 am

Sean Nash

Align comment.

Align comment.

9:15 am

Sean Nash

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Tuesday 21 Jul
4:55 pm

Sean Nash

Change INPROGRESS to OPEN (because you're going to remove INPROGRESS).

Change INPROGRESS to OPEN (because you're going to remove INPROGRESS).

4:32 pm

Sean Nash

You can do this sendMessage just once after else.

You can do this sendMessage just once after else.

10:35 am

Vendor - TEL - Arpita Srivastava

add a space before and after 0

add a space before and after 0

10:35 am

Vendor - TEL - Arpita Srivastava

add a blank line above

add a blank line above

10:33 am

Vendor - TEL - Arpita Srivastava

add a blank line above

add a blank line above

10:27 am

Vendor - TEL - Arpita Srivastava

minor spell issue : change responceStatus to responseStatus

minor spell issue : change responceStatus to responseStatus

10:26 am

Vendor - TEL - Arpita Srivastava

add offRequestAwaitingUserConfirmation and offRequestPendingTimer to outputs

add offRequestAwaitingUserConfirmation and offRequestPendingTimer to outputs

10:24 am

Vendor - TEL - Arpita Srivastava

should we move the initialization in the init function?

should we move the initialization in the init function?

10:19 am

Vendor - TEL - Arpita Srivastava

please break this line into two lines

please break this line into two lines

10:19 am

Vendor - TEL - Arpita Srivastava

Vendor - TEL - Arpita Srivastava please add a space before and after in sizeof(U32) in [sizeof(U32)]

Vendor - TEL - Arpita Srivastava
please add a space before and after in sizeof(U32) in [sizeof(U32)]

10:16 am

Vendor - TEL - Arpita Srivastava

please add a space before and after 0 in payload[0]

please add a space before and after 0 in payload[0]

10:15 am

Vendor - TEL - Arpita Srivastava

output is none

output is none

10:13 am

Vendor - TEL - Arpita Srivastava

please break the line in two or more.

please break the line in two or more.

10:12 am

Vendor - TEL - Arpita Srivastava

add a space before and after index 'i'

add a space before and after index 'i'

10:12 am

Vendor - TEL - Arpita Srivastava

add a space before and after index 'i'

add a space before and after index 'i'

10:12 am

Vendor - TEL - Arpita Srivastava

add a space before and after index 'i'

add a space before and after index 'i'