Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Updated

Updated

fixed

fixed

Align the comments.

Align the comments.

LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LDT-3984: fixes for defeatured operation

    • -14
    • +21
    ./FPModes/StateFlushFilterDefeatured.c
  1. … 3 more files in changeset.
COMM_BUFFER_OUT_CAN_FP_BROADCAST sendEvent check the event ID. if it is an FP event, FP event will be sent on COMM_BUFFER_OUT_CAN_FP_BROADCAST

COMM_BUFFER_OUT_CAN_FP_BROADCAST

sendEvent check the event ID. if it is an FP event, FP event will be sent on COMM_BUFFER_OUT_CAN_FP_BROADCAST

Do we know which channel this event will be sent on?

Do we know which channel this event will be sent on?

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 11 more files in changeset.
LDT-3352 resolving merge issues

  1. … 9 more files in changeset.
LEAHI-DD-FIRMWARE-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
LEAHI-DD-FIRMWARE-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Reduced gain and testing in progress.

Done.

Done.

Done.

Done.

LDT-3352 code review comments update

  1. … 6 more files in changeset.