leahi-common

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Please add the min and max for tmp as well in the outputs.

Please add the min and max for tmp as well in the outputs.

rejReason = INVALID REQUEST FORMAT

rejReason = INVALID REQUEST FORMAT

Missing comment.

Missing comment.

update comment. next one as well.

update comment. next one as well.

blank line after the banner and maintain alphabetical order of include files.

blank line after the banner and maintain alphabetical order of include files.

LEAHI-COMMON-LDT-4000_HDF - FW Implementation - 1/4:
LEAHI-COMMON-LDT-4000_HDF - FW Implementation - 1/4:
LDT-4001: updates to msg ids'

LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
LDT-4000: substitution pump override ids. floater level override request.

Why would change request from UI come in separate messages (1 for duration and 1 for volume)?

Why would change request from UI come in separate messages (1 for duration and 1 for volume)?

How can settings be pending when you set that flag to TRUE in the code below this? And why would we want to use uf volume setting in the else part of this ternary?

How can settings be pending when you set that flag to TRUE in the code below this? And why would we want to use uf volume setting in the else part of this ternary?

else reason is Invalid Request Format

else reason is Invalid Request Format

Should check if iso UF volume + UF volume < max. And if user can do multiple iso uf sessions, you would check iso UF volume + any previous iso UF volume + UF volume. I don't know if there is a mini...

Should check if iso UF volume + UF volume < max. And if user can do multiple iso uf sessions, you would check iso UF volume + any previous iso UF volume + UF volume.
I don't know if there is a minimum iso UF volume.

Looking for "less than current" only makes sense if user can do multiple iso UF sessions in a treatment. And if that's the case, we should be looking at how much time we've already spent doing iso ...

Looking for "less than current" only makes sense if user can do multiple iso UF sessions in a treatment. And if that's the case, we should be looking at how much time we've already spent doing iso UF instead of how much time we've spent in the HD or HDF treatment.

I think we have to check whether the iso uf duration + treatment duration does not exceed maximum treatment duration. And I'm not sure if there is a minimum duration for iso uf, but if there is a m...

I think we have to check whether the iso uf duration + treatment duration does not exceed maximum treatment duration.
And I'm not sure if there is a minimum duration for iso uf, but if there is a minimum, it probably isn't the same as the minimum treatment duration.

Just add this as an AND condition in the if statement above.

Just add this as an AND condition in the if statement above.

If we are in treatment end state, the treatment is completed (no need to check that) and I don't think iso UF is a modality.

If we are in treatment end state, the treatment is completed (no need to check that) and I don't think iso UF is a modality.

Do we need this? Check with Raghu. I don't think iso UF is a modality (at least not yet).

Do we need this? Check with Raghu. I don't think iso UF is a modality (at least not yet).

Align all or none of the =

Align all or none of the =

I don't think iso uf is considered a modality - at least not in phase 1 of development.

I don't think iso uf is considered a modality - at least not in phase 1 of development.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

Can we restore the real code here yet? Ask Dara.

Can we restore the real code here yet? Ask Dara.

use ternary to make TRUE or FALSE.

use ternary to make TRUE or FALSE.

Fixed

Fixed

Yes

Yes

REmoved

REmoved

Moved

Moved

Fixed

Fixed

Removed

Removed