leahi-fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
rejReason = INVALID REQUEST FORMAT

rejReason = INVALID REQUEST FORMAT

Missing comment.

Missing comment.

update comment. next one as well.

update comment. next one as well.

blank line after the banner and maintain alphabetical order of include files.

blank line after the banner and maintain alphabetical order of include files.

LEAHI-FWCOMMON-LDT-4000_HDF - FW Implementation - 1/4:
LEAHI-FWCOMMON-LDT-4000_HDF - FW Implementation - 1/4:
LDT-4001: updates to dialysate request message payload.

LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
Done.

Done.

I think we also need this to be uncommented, as we were running into an alarm because of this.

I think we also need this to be uncommented, as we were running into an alarm because of this.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

as discussed, these were outcome of the test results. we will review these gains with latest controller.

as discussed, these were outcome of the test results. we will review these gains with latest controller.

Done.

Done.

Done.

Done.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

Can we restore the real code here yet? Ask Dara.

Can we restore the real code here yet? Ask Dara.

Why isn't this TRUE == ?

Why isn't this TRUE == ?

LEAHI-TD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-TD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merged LDT-3259

Done

Done

LDT-3259 addressed the code review comments

Done

Done

This file was updated automatically using HALCoGen.

This file was updated automatically using HALCoGen.

Done

Done

Done

Done

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.