dd-firmware

firmware

Clone Tools

Stats

Commits this week: 28
Total Committers: 21
Last Commit: 03 Jun
Commits this week: 28

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
12 hrs ago

Sean Nash

Ok to reject for now (because we don't want TD to go to disinfection state while DD doesn't). Add TODO to handle other disinfection options when they are implemented.

Ok to reject for now (because we don't want TD to go to disinfection state while DD doesn't). Add TODO to handle other disinfection options when they are implemented.

12 hrs ago

Sean Nash

Add a blank line between banner and comment.

Add a blank line between banner and comment.

12 hrs ago

Sean Nash

gen to post gen and post gen to standby are simple commands unlike the pre-gen and gen dialysate requests which have a bunch of parameters. I think we should keep the simple transition requests in ...

gen to post gen and post gen to standby are simple commands unlike the pre-gen and gen dialysate requests which have a bunch of parameters. I think we should keep the simple transition requests in this enum with the disinfection requests and eventually any other simple command requests.

12 hrs ago

Sean Nash

DD only needs a command to start a specific disinfection. This can be achieved with the one generic command message here.

DD only needs a command to start a specific disinfection. This can be achieved with the one generic command message here.

12 hrs ago

Sean Nash

I was thinking we would have a generic command message with a single enum for the command ID. This one message could handle many different commands including post get to standby command.

I was thinking we would have a generic command message with a single enum for the command ID. This one message could handle many different commands including post get to standby command.

Friday 21 Aug
5:20 pm

Vendor - TEL - Jashwant Gantyada

5:09 pm

Vendor - TEL - Vijay Pamula , Sean Nash and Vinayakam Mani

5:08 pm

Vendor - TEL - Vijay Pamula

5:07 pm

Vendor - TEL - Jashwant Gantyada

added

added

5:02 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

4:32 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5155_(DD) D79 rinse pump does not run when commanded (staging 94+)
LEAHI-DD-FIRMWARE-LDT-5155_(DD) D79 rinse pump does not run when commanded (staging 94+)
10:57 am

Vinayakam Mani

Please add another sub condition for now that sub mode is in DD_POST_GEN_DIALYSATE_STATE_COMPLETE. Make sure you transition substate from Post gen start state to complete state for now to wait for ...

Please add another sub condition for now that sub mode is in DD_POST_GEN_DIALYSATE_STATE_COMPLETE. Make sure you transition substate from Post gen start state to complete state for now to wait for this request.

10:57 am

Michael Garthwaite

for now, keep this only related for disinfection cmds. for Post gen and standby. Follow the similiar messaging like pre-gen and gen dialysate requests and the reply back. ( but one message/handler )

for now, keep this only related for disinfection cmds.

for Post gen and standby. Follow the similiar messaging like pre-gen and gen dialysate requests and the reply back. ( but one message/handler )

10:50 am

Vinayakam Mani

are we rejecting this request for Aug Month demo, I guess, you still need to accept these requests and set the corresponding pending DD disinfect request flags.

are we rejecting this request for Aug Month demo, I guess, you still need to accept these requests and set the corresponding pending DD disinfect request flags.

10:47 am

Michael Garthwaite

Do we have a MSG_ID for the selection of disinfection? If not, lets rename and repurpose this one.

Do we have a MSG_ID for the selection of disinfection? If not, lets rename and repurpose this one.

10:44 am

Vinayakam Mani

MSG_ID_TD_DD_POSTGEN_STANDBY_REQUEST: to perform post gen and standby mode request transition.

MSG_ID_TD_DD_POSTGEN_STANDBY_REQUEST: to perform post gen and standby mode request transition.

10:36 am

Michael Garthwaite

Thursday 20 Aug
1:48 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5470_Post Treatment - FW Implementation - 4/3:
LEAHI-DD-FIRMWARE-LDT-5470_Post Treatment - FW Implementation - 4/3:
1:32 pm

Vendor - TEL - Suresh Dharnala

1:22 pm

Sean Nash

Add TODO to restore later. Why did this need to be commented out?

Add TODO to restore later. Why did this need to be commented out?

1:19 pm

Sean Nash

Remove blank line.

Remove blank line.

1:17 pm

Sean Nash

Restore before merging.

Restore before merging.

11:50 am

Michael Garthwaite and Vinayakam Mani

Wednesday 19 Aug
1:40 pm

Michael Garthwaite

flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

flip the logic such that featured is the IF and not the ELSE to avoid having a blank branch statement

12:28 pm

Vinayakam Mani

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

11:14 am

Vinayakam Mani

Add D92 pump On at 50ml/min.

Add D92 pump On at 50ml/min.

11:11 am

Vinayakam Mani

Remove D95 from closed state and add D88 to closed state.

Remove D95 from closed state and add D88 to closed state.

11:07 am

Vinayakam Mani

D35, D40, D34,D91,D95 : Open M12, P39 : Closed ( keep a TODO comment to remove them later)

D35, D40, D34,D91,D95 : Open
M12, P39 : Closed ( keep a TODO comment to remove them later)

10:59 am

Vinayakam Mani

close D80, D64, D14?

close D80, D64, D14?

10:56 am

Vinayakam Mani

D80 : open, D65: Close?

D80 : open, D65: Close?