td-firmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 7
Total Committers: 11
Last Commit: 11 May
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
5 hrs ago

Sean Nash

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

5 hrs ago

Sean Nash

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

5 hrs ago

Sean Nash

Use OVERRIDE_RESET for .override instead of 0.

Use OVERRIDE_RESET for .override instead of 0.

6 hrs ago

Vendor - TEL - Arpita Srivastava

We can rename priorState to previousInstallState. Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

We can rename priorState to previousInstallState.
Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

6 hrs ago

Sean Nash and Vendor - TEL - Arpita Srivastava

8 hrs ago

Vendor - TEL - Jashwant Gantyada

align indentation, same for line 338 as well.

align indentation, same for line 338 as well.

8 hrs ago

Vendor - TEL - Arpita Srivastava

Yes. Otherwise, we will have to hard code the calibration record for the time being.

Yes.
Otherwise, we will have to hard code the calibration record for the time being.

8 hrs ago

Vendor - TEL - Arpita Srivastava

The function getSoftwareConfigStatus() is also part of NVM module. Moreover, we are planning to remove this function when NVM will be implemented. So, we will have to perform a cleanup and remove a...

The function getSoftwareConfigStatus() is also part of NVM module.
Moreover, we are planning to remove this function when NVM will be implemented.
So, we will have to perform a cleanup and remove all similar calls that have been currently commented out in other files as well like AirTrap.c, BloodFlow.c, etc.

10 hrs ago

Sean Nash

Is this the right time to zero this volume?

Is this the right time to zero this volume?

10 hrs ago

Sean Nash

update total volume too?

update total volume too?

10 hrs ago

Sean Nash

maybe use target rate for both.

maybe use target rate for both.

10 hrs ago

Sean Nash

Use #define for array size.

Use #define for array size.

10 hrs ago

Sean Nash

Make the 6 a #define

Make the 6 a #define

10 hrs ago

Sean Nash

only 1 return statement

only 1 return statement

10 hrs ago

Sean Nash

remove comma

remove comma

10 hrs ago

Sean Nash

return FALSE on else

return FALSE on else

10 hrs ago

Sean Nash

signal functions should return BOOL.

signal functions should return BOOL.

11 hrs ago

Sean Nash

Move up with rest

Move up with rest

11 hrs ago

Sean Nash

Move this function to your service.

Move this function to your service.

11 hrs ago

Sean Nash

Add HDF state too

Add HDF state too

11 hrs ago

Sean Nash

Not needed.

Not needed.

11 hrs ago

Sean Nash

Should always exec your bolus sm.

Should always exec your bolus sm.

11 hrs ago

Sean Nash

Keep 2 blank lines before banner

Keep 2 blank lines before banner

11 hrs ago

Sean Nash

Add fluid bolus state

Add fluid bolus state

11 hrs ago

Sean Nash

Add fluid bolus state

Add fluid bolus state

11 hrs ago

Sean Nash

FLUID_BOLUS_CMD_EVENT

FLUID_BOLUS_CMD_EVENT

Tuesday 19 May
5:39 pm

Sean Nash

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

5:37 pm

Sean Nash

Remove this blank line.

Remove this blank line.

3:37 pm

Vendor - TEL - Arpita Srivastava

There is still merge conflict? Please resolve merge conflict and build the code in your local before pushing.

There is still merge conflict?
Please resolve merge conflict and build the code in your local before pushing.

3:35 pm

Sean Nash

This merge conflict is still unresolved.

This merge conflict is still unresolved.