td-firmware / firmware / App / Services

Messaging.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 5
Last Commit: 11 May
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
11 hrs ago

Sean Nash

Is this the right time to zero this volume?

Is this the right time to zero this volume?

11 hrs ago

Sean Nash

update total volume too?

update total volume too?

11 hrs ago

Sean Nash

maybe use target rate for both.

maybe use target rate for both.

11 hrs ago

Sean Nash

Use #define for array size.

Use #define for array size.

11 hrs ago

Sean Nash

Make the 6 a #define

Make the 6 a #define

11 hrs ago

Sean Nash

only 1 return statement

only 1 return statement

11 hrs ago

Sean Nash

remove comma

remove comma

11 hrs ago

Sean Nash

return FALSE on else

return FALSE on else

11 hrs ago

Sean Nash

signal functions should return BOOL.

signal functions should return BOOL.

12 hrs ago

Sean Nash

Move up with rest

Move up with rest

12 hrs ago

Sean Nash

Move this function to your service.

Move this function to your service.

12 hrs ago

Sean Nash

Add HDF state too

Add HDF state too

12 hrs ago

Sean Nash

Not needed.

Not needed.

12 hrs ago

Sean Nash

Should always exec your bolus sm.

Should always exec your bolus sm.

12 hrs ago

Sean Nash

Keep 2 blank lines before banner

Keep 2 blank lines before banner

12 hrs ago

Sean Nash

Add fluid bolus state

Add fluid bolus state

12 hrs ago

Sean Nash

Add fluid bolus state

Add fluid bolus state

12 hrs ago

Sean Nash

FLUID_BOLUS_CMD_EVENT

FLUID_BOLUS_CMD_EVENT

Sunday 17 May
11:46 pm

Sean Nash

Why was this function header changed? I think it was correct before.

Why was this function header changed? I think it was correct before.

11:37 pm

Sean Nash

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

Thursday 14 May
9:48 am

Vendor - TEL - Arpita Srivastava

Looks like the description part should only be in the @param part. sysConfigTreatmentParameters should be an output? Input is None. Add @details for alarms

Looks like the description part should only be in the @param part.
sysConfigTreatmentParameters should be an output? Input is None.
Add @details for alarms

9:29 am

Vendor - TEL - Arpita Srivastava

align comment

align comment

9:26 am

Vendor - TEL - Arpita Srivastava

The Id name looks too long? What if we change Temperature to Temp?

The Id name looks too long? What if we change Temperature to Temp?

Tuesday 12 May
3:44 pm

Vendor - TEL - Arpita Srivastava

Please list names of variables in inputs and outputs. You can move any description in the brief section.

Please list names of variables in inputs and outputs.
You can move any description in the brief section.

2:24 pm

Vendor - TEL - Arpita Srivastava

Please add a comment for this check and break the line in two lines.

Please add a comment for this check and break the line in two lines.

2:24 pm

Vendor - TEL - Arpita Srivastava

Please add a comment about this condition check. Move this part : ( fabs( request.ufRate - validatedUFRateLhr ) < NEARLY_ZERO ) ) to the next line.

Please add a comment about this condition check.

Move this part : ( fabs( request.ufRate - validatedUFRateLhr ) < NEARLY_ZERO ) ) to the next line.

2:18 pm

Vendor - TEL - Arpita Srivastava

Can we please align (move more towards right) the comments of this newly added section with the comments of existing sections?

Can we please align (move more towards right) the comments of this newly added section with the comments of existing sections?

2:00 pm

Vendor - TEL - Arpita Srivastava

Please keep on declaration of the variables in this section and move the initialization to initTreatmentParameters

Please keep on declaration of the variables in this section and move the initialization to initTreatmentParameters

1:59 pm

Vendor - TEL - Arpita Srivastava

Please rename this function to initTreatmentParameters

Please rename this function to initTreatmentParameters

1:56 pm

Vendor - TEL - Arpita Srivastava

Even if you do not have an Output, please add the tag with None as the value. Please fix in other functions as well.

Even if you do not have an Output, please add the tag with None as the value.
Please fix in other functions as well.