Monitors

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
where are we calling an alarm? i think we are only sending event change data in completeBolusToCumulative() right?

where are we calling an alarm?
i think we are only sending event change data in completeBolusToCumulative() right?

do we need this block?

do we need this block?

update the comment as required: ml or L?

update the comment as required: ml or L?

Please add the min and max for tmp as well in the outputs.

Please add the min and max for tmp as well in the outputs.

rejReason = INVALID REQUEST FORMAT

rejReason = INVALID REQUEST FORMAT

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

Can we restore the real code here yet? Ask Dara.

Can we restore the real code here yet? Ask Dara.

Not a float.

Not a float.

Not a float.

Not a float.

Not a float anymore. Use u32Override function and no need to cast the pointer.

Not a float anymore. Use u32Override function and no need to cast the pointer.

Should we publish all registers read?

Should we publish all registers read?

Remove this comment since we have a comment to right.

Remove this comment since we have a comment to right.

Remove comment.

Remove comment.

REG_ADDRESSES

REG_ADDRESSES

DEVICE_ADDRESSES

DEVICE_ADDRESSES

Set them individually instead of with memset.

Set them individually instead of with memset.

Add blank line before a /// comment.

Add blank line before a /// comment.

device and register is fine. Or deviceSel and registerSel.

device and register is fine. Or deviceSel and registerSel.

Done

Done

Done

Done

Use the NEARLY_ZERO constant (instead 0f 0.01F) like the other one.

Use the NEARLY_ZERO constant (instead 0f 0.01F) like the other one.

Add a doxygen comment above this array.

Add a doxygen comment above this array.

Add a doxygen comment above this array (similar to structures).

Add a doxygen comment above this array (similar to structures).