ModeTreatment.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Is rinseback completed an indication that we've done a blood prime following a temporary break? If so, I guess this makes sense, but we have to do more than increase the UF volume. We have to adjus...

Is rinseback completed an indication that we've done a blood prime following a temporary break?
If so, I guess this makes sense, but we have to do more than increase the UF volume. We have to adjust the UF rate so that we will reach the new (larger) UF volume when the treatment completes.
We also need to add RB volume to UF volume in pre-tx when treatment parameters are given/validated (for the final rinseback which we will always have so we should just plan for it before treatment starts).

What if multiple confirmations pending? Which ID will this function return?

What if multiple confirmations pending? Which ID will this function return?

Align comments. Should substitution pump data be moved down to 0xBA instead of commented out?

Align comments.
Should substitution pump data be moved down to 0xBA instead of commented out?

LEAHI-TD-FIRMWARE-LDT-4040_Rinseback - FW Implementation - 3/10:
LEAHI-TD-FIRMWARE-LDT-4040_Rinseback - FW Implementation - 3/10:
Remove extra ;

Remove extra ;

Can we align comments?

Can we align comments?

Missing pinch valves (H1 and H19).

Missing pinch valves (H1 and H19).

Remove this blank line.

Remove this blank line.

this function should not return anything.

this function should not return anything.

Please rename all the sPump registers as h10 for consistency.

Please rename all the sPump registers as h10 for consistency.

Add bpMeasurementReady, bpDriverError and pendingBPCommand to outputs.

Add bpMeasurementReady, bpDriverError and pendingBPCommand to outputs.

Fixed

Fixed

Added

Added

Fixed

Fixed

Fixed

Fixed

Fixed

Fixed

Not required here since we are initializing in the main

Not required here since we are initializing in the main

Yes removed

Yes removed

Fixed

Fixed

Fixed

Fixed

please add message id.

please add message id.

We should set all TD actuators here, not just blood pump.

We should set all TD actuators here, not just blood pump.

fpgaActuatorSetPoints is an output. Input is none.

fpgaActuatorSetPoints is an output.
Input is none.

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

Change "SetupConnection" to "SetupTubingSetConnection"

Change "SetupConnection" to "SetupTubingSetConnection"

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

Include "BPModule.h".

Include "BPModule.h".

BPModule is just one of the controllers - move this up into the controllers section.

BPModule is just one of the controllers - move this up into the controllers section.