td-firmware / firmware / App / Modes

ModeTreatment.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 5
Last Commit: 11 May
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 12 May
3:47 pm

Vendor - TEL - Arpita Srivastava

Add @param section for reasons.

Add @param section for reasons.

3:44 pm

Vendor - TEL - Arpita Srivastava

Please list names of variables in inputs and outputs. You can move any description in the brief section.

Please list names of variables in inputs and outputs.
You can move any description in the brief section.

2:24 pm

Vendor - TEL - Arpita Srivastava

Please add a comment for this check and break the line in two lines.

Please add a comment for this check and break the line in two lines.

2:24 pm

Vendor - TEL - Arpita Srivastava

Please add a comment about this condition check. Move this part : ( fabs( request.ufRate - validatedUFRateLhr ) < NEARLY_ZERO ) ) to the next line.

Please add a comment about this condition check.

Move this part : ( fabs( request.ufRate - validatedUFRateLhr ) < NEARLY_ZERO ) ) to the next line.

2:18 pm

Vendor - TEL - Arpita Srivastava

Can we please align (move more towards right) the comments of this newly added section with the comments of existing sections?

Can we please align (move more towards right) the comments of this newly added section with the comments of existing sections?

2:00 pm

Vendor - TEL - Arpita Srivastava

Please keep on declaration of the variables in this section and move the initialization to initTreatmentParameters

Please keep on declaration of the variables in this section and move the initialization to initTreatmentParameters

1:59 pm

Vendor - TEL - Arpita Srivastava

Please rename this function to initTreatmentParameters

Please rename this function to initTreatmentParameters

1:56 pm

Vendor - TEL - Arpita Srivastava

Even if you do not have an Output, please add the tag with None as the value. Please fix in other functions as well.

Even if you do not have an Output, please add the tag with None as the value.
Please fix in other functions as well.

1:54 pm

Vendor - TEL - Arpita Srivastava

Please indent the doxygen comments of all the functions, similar to existing functions.

Please indent the doxygen comments of all the functions, similar to existing functions.

Monday 11 May
5:41 pm

Vendor - TEL - Arpita Srivastava

origTreatmentParams should be an output?

origTreatmentParams should be an output?

5:39 pm

Vendor - TEL - Arpita Srivastava

Please enclose each condition in parenthesis

Please enclose each condition in parenthesis

5:34 pm

Vendor - TEL - Arpita Srivastava

Can you please move the TODO comment above this line?

Can you please move the TODO comment above this line?

5:32 pm

Vendor - TEL - Arpita Srivastava

Please add a comment for this check.

Please add a comment for this check.

5:31 pm

Vendor - TEL - Arpita Srivastava

Please add @param

Please add @param

5:29 pm

Vendor - TEL - Arpita Srivastava

Please add @param

Please add @param

5:28 pm

Vendor - TEL - Arpita Srivastava

treatParamsConfirmed should be an output?

treatParamsConfirmed should be an output?

5:25 pm

Vendor - TEL - Arpita Srivastava

Delete extra line

Delete extra line

4:58 pm

Vendor - TEL - Arpita Srivastava

Please assign it to FALSE

Please assign it to FALSE

4:57 pm

Vendor - TEL - Arpita Srivastava

Please add details of you message Id by using this format. @details \b Message \b Sent:

Please add details of you message Id by using this format.

@details \b Message \b Sent:

4:56 pm

Vendor - TEL - Arpita Srivastava

Place add \b before Outputs.

Place add \b before Outputs.

4:55 pm

Vendor - TEL - Arpita Srivastava

Place add \b before Outputs.

Place add \b before Outputs.

Wednesday 06 May
5:55 pm

Sean Nash

Same comment as duration confirmation. compare uf rate too.

Same comment as duration confirmation. compare uf rate too.

5:44 pm

Sean Nash

Also check uf rate from confirmation message (request) is still the same as validated uf rate. WARNING - uf rate will be a float and we shouldn't use == operator on floats.

Also check uf rate from confirmation message (request) is still the same as validated uf rate.
WARNING - uf rate will be a float and we shouldn't use == operator on floats.

5:38 pm

Sean Nash

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

5:38 pm

Sean Nash

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

Tuesday 05 May
6:54 pm

Sean Nash

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

6:52 pm

Sean Nash

2 lines above/below banner

2 lines above/below banner

6:48 pm

Sean Nash

remove blank line.

remove blank line.

6:25 pm

Sean Nash

use response.x for these.

use response.x for these.

6:25 pm

Sean Nash

use response.duration.

use response.duration.