td-firmware / firmware / App / Controllers

SyringePump.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 4
Last Commit: 03 Aug
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
5 hrs ago

Vendor - TEL - Suresh Dharnala

Wednesday 05 Aug
4:54 pm

Vendor - TEL - Arpita Srivastava and Sean Nash

3:58 pm

Vendor - TEL - Arpita Srivastava

These new functions should be above the test functions. Please align with the Messaging.c file. It looks correct in the Messaging.c file.

These new functions should be above the test functions.

Please align with the Messaging.c file.
It looks correct in the Messaging.c file.

3:54 pm

Vendor - TEL - Arpita Srivastava

Move this above the test functions.

Move this above the test functions.

3:45 pm

Vendor - TEL - Arpita Srivastava

What is the use case of this header include?

What is the use case of this header include?

12:45 pm

Sean Nash

What if we're in paused state (because your alarm has stop property set)? Should we return TRUE here if in paused state and interrupted state was the await syringe load confirmation state?

What if we're in paused state (because your alarm has stop property set)? Should we return TRUE here if in paused state and interrupted state was the await syringe load confirmation state?

12:40 pm

Sean Nash

Right now, the load syringe alarm indicates stop so we will go to paused state. Is that what we want to do? Don't we want to stay in this state and wait for confirmation?

Right now, the load syringe alarm indicates stop so we will go to paused state. Is that what we want to do? Don't we want to stay in this state and wait for confirmation?

12:37 pm

Sean Nash

Should this alarm have stop property set to FALSE?

Should this alarm have stop property set to FALSE?

Tuesday 04 Aug
11:16 am

Vendor - TEL - Arpita Srivastava

align comment

align comment

10:13 am

Vendor - TEL - Arpita Srivastava

When we send any message to UI, usually add the message id in the doxygen header like this. @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the function s...

When we send any message to UI, usually add the message id in the doxygen header like this.

@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE

Please refer to the function sendTreatmentParamsResponse()

10:05 am

Vendor - TEL - Arpita Srivastava

When we send any message to UI, usually add the message id in the doxygen header like this. *@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the functi...

When we send any message to UI, usually add the message id in the doxygen header like this.

  • @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE


Please refer to the function sendTreatmentParamsResponse()

10:05 am

Vendor - TEL - Arpita Srivastava

When we send any message to UI, usually add the message id in the doxygen header like this. *@details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE Please refer to the functi...

When we send any message to UI, usually add the message id in the doxygen header like this.

  • @details \b Message \b Sent: MSG_ID_TD_RESP_TREATMENT_PARAMS_TO_VALIDATE


Please refer to the function sendTreatmentParamsResponse()

9:55 am

Vendor - TEL - Arpita Srivastava

It looks like the rows may be misaligned with the alarm ID declarations. For example, ALARM_ID_TD_SAFETY_SHUTDOWN_POST_TEST_FAILED is declared as 207.

It looks like the rows may be misaligned with the alarm ID declarations.
For example, ALARM_ID_TD_SAFETY_SHUTDOWN_POST_TEST_FAILED is declared as 207.

9:53 am

Vendor - TEL - Arpita Srivastava

Should Instructions part be this? A problem was detected with the hemodialysis device.

Should Instructions part be this?

A problem was detected with the hemodialysis device.

9:50 am

Vendor - TEL - Arpita Srivastava

Please confirm if the source is DD?

Please confirm if the source is DD?

Friday 31 Jul
9:33 am

Vendor - TEL - Arpita Srivastava

What is the use case of including this header?

What is the use case of including this header?

9:33 am

Vendor - TEL - Arpita Srivastava

What is the use case of including this header?

What is the use case of including this header?

9:32 am

Vendor - TEL - Arpita Srivastava

Should we move this up before the test functions?

Should we move this up before the test functions?

9:32 am

Vendor - TEL - Arpita Srivastava

Add @messages MSG_ID_TD_POST_FINAL_TEST_RESULT

Add @messages MSG_ID_TD_POST_FINAL_TEST_RESULT

9:32 am

Vendor - TEL - Arpita Srivastava

Add @messages MSG_ID_TD_POST_SINGLE_TEST_RESULT

Add @messages MSG_ID_TD_POST_SINGLE_TEST_RESULT

9:31 am

Vendor - TEL - Arpita Srivastava

is the function description correct? change DG -> DD

is the function description correct?
change DG -> DD

9:31 am

Vendor - TEL - Arpita Srivastava

output is none

output is none

9:30 am

Vendor - TEL - Arpita Srivastava

add safetyShutdownSelfTestStatus to outputs

add safetyShutdownSelfTestStatus to outputs

9:28 am

Vendor - TEL - Arpita Srivastava

why is this line commented out? Should we remove it or add a TODO?

why is this line commented out? Should we remove it or add a TODO?

9:27 am

Vendor - TEL - Arpita Srivastava

Remove blank line

Remove blank line

9:26 am

Vendor - TEL - Arpita Srivastava

align comment

align comment

9:26 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

9:25 am

Vendor - TEL - Arpita Srivastava

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

9:25 am

Vendor - TEL - Arpita Srivastava

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

9:24 am

Vendor - TEL - Arpita Srivastava

remove blank line

remove blank line