Activity td-firmware/

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before en...

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before entering Pre-Treatment.

9:02 am

Dara Navaei

More
LEAHI-TD-FIRMWARE-LDT-5214-1
started review

LEAHI-TD-FIRMWARE-LDT-5214_[FW+Dialin] New override for Air Pump Measured Speed parameter

10:23 am

suresh

More
ad2492d
changed 2 files
LDT-4063-power-control-and-post---fw-imp LEAHI-TD-FIRMWARE-LDT-4063-1

LDT-4063: UI_PAYLOAD_T Updated

- -6
- +7
/firmware/App/Modes/OperationModes.c
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.c
- -1
- +1
/firmware/App/Services/Messaging.h
- History
- Source
- Diff
/firmware/App/Services/Messaging.h

10:13 am

suresh

More
f99f8b3
changed 7 files
LDT-4063-power-control-and-post---fw-imp LEAHI-TD-FIRMWARE-LDT-4063-1

LDT:4063 Addressed review comments

- -18
- +34
/firmware/App/Modes/ModeInitPOST.c
- History
- Source
- Diff
/firmware/App/Modes/ModeInitPOST.c
- -92
- +40
/firmware/App/Modes/OperationModes.c
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.c
- -2
- +0
/firmware/App/Modes/OperationModes.h
- History
- Source
- Diff
/firmware/App/Modes/OperationModes.h
- -109
- +98
/firmware/App/Monitors/Buttons.c
- History
- Source
- Diff
/firmware/App/Monitors/Buttons.c
- -11
- +1
/firmware/App/Monitors/Buttons.h
- History
- Source
- Diff
/firmware/App/Monitors/Buttons.h
- -41
- +30
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c
- -1
- +9
/firmware/App/Services/Messaging.h
- History
- Source
- Diff
/firmware/App/Services/Messaging.h

3:03 pm

Dara Navaei

More
LEAHI-TD-FIRMWARE-LDT-4611-4
started review

LEAHI-TD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:

9:15 am

Vendor - TEL - Arpita Srivastava

More
LEAHI-TD-FIRMWARE-LDT-4028-2
finished reviewing

11:17 pm

Sean Nash

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmatio...

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmation msg is received.

11:10 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4029-1
commented on review

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

5:55 pm