td-firmware / firmware / App / Modes

StateTxDialysis.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 3
Last Commit: 27 May
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 29 May
2:25 pm

Sean Nash

rejReason = INVALID REQUEST FORMAT

rejReason = INVALID REQUEST FORMAT

Thursday 28 May
10:43 pm

Sean Nash

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

10:33 pm

Sean Nash

Can we restore the real code here yet? Ask Dara.

Can we restore the real code here yet? Ask Dara.

Wednesday 20 May
12:09 pm

Sean Nash

maybe use target rate for both.

maybe use target rate for both.

11:41 am

Sean Nash

Use #define for array size.

Use #define for array size.

11:40 am

Sean Nash

Make the 6 a #define

Make the 6 a #define

11:39 am

Sean Nash

only 1 return statement

only 1 return statement

11:35 am

Sean Nash

remove comma

remove comma

11:24 am

Sean Nash

signal functions should return BOOL.

signal functions should return BOOL.

11:20 am

Sean Nash

Move up with rest

Move up with rest

11:17 am

Sean Nash

Move this function to your service.

Move this function to your service.

11:09 am

Sean Nash

Not needed.

Not needed.

11:06 am

Sean Nash

Should always exec your bolus sm.

Should always exec your bolus sm.

11:01 am

Sean Nash

Keep 2 blank lines before banner

Keep 2 blank lines before banner

10:59 am

Sean Nash

Add fluid bolus state

Add fluid bolus state

10:59 am

Sean Nash

Add fluid bolus state

Add fluid bolus state

Tuesday 05 May
9:17 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4:
LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4:
Tuesday 22 Apr 2025
10:51 am

Sean Nash

10:31 am

Vinayakam Mani and Michael Garthwaite

9:39 am

Michael Garthwaite

RESOLVED.

RESOLVED.

9:39 am

Michael Garthwaite

RESOLVED.

RESOLVED.

9:35 am

Sean Nash

These get set (lines 485 and 488) before they are used (line 491). No need to initialize before then.

These get set (lines 485 and 488) before they are used (line 491). No need to initialize before then.

9:32 am

Sean Nash

OperationModes.c init function is only at power up. This call to init treatment mode is intended to re-init treatment mode before each treatment starts.

OperationModes.c init function is only at power up. This call to init treatment mode is intended to re-init treatment mode before each treatment starts.

9:22 am

Michael Garthwaite

Shouldn't these bools be set to a specific value?

Shouldn't these bools be set to a specific value?

9:19 am

Michael Garthwaite

this init is already being called in operationmode.c's init function. Do we need the redundancy?

this init is already being called in operationmode.c's init function. Do we need the redundancy?

8:41 am

Sean Nash

Done.

Done.

Monday 21 Apr 2025
5:16 pm

Sean Nash

Fixed.

Fixed.

5:15 pm

Sean Nash

Fixed.

Fixed.

5:14 pm

Sean Nash

Fixed.

Fixed.

5:13 pm

Sean Nash

Removed. Not necessary.

Removed. Not necessary.