td-firmware / firmware / App

Monitors

Clone Tools

Stats

Commits this week: 6
Total Committers: 9
Last Commit: 18 Jul
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 18 Jul
10:13 am

suresh

LDT:4063 Addressed review comments

Options
    • -109
    • +98
    ./Buttons.c
    • -11
    • +1
    ./Buttons.h
  3. … 5 more files in changeset.
Wednesday 15 Jul
9:15 am

Vendor - TEL - Arpita Srivastava

Tuesday 14 Jul
11:17 pm

Sean Nash

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmatio...

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmation msg is received.

11:10 pm

Sean Nash

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

5:55 pm

Sean Nash

5:53 pm

Sean Nash

171

171

9:39 am

Sean Nash

Update all function headers in this file to Leahi style (e.g. \b before inputs/outputs).

Update all function headers in this file to Leahi style (e.g. \b before inputs/outputs).

9:38 am

Sean Nash

Add extra line (should be 2 lines) after test support banner.

Add extra line (should be 2 lines) after test support banner.

9:36 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:35 am

Sean Nash

Update function header format from Denali to Leahi style (e.g. \b for inputs/outputs) throughout this file.

Update function header format from Denali to Leahi style (e.g. \b for inputs/outputs) throughout this file.

9:26 am

Vendor - TEL - Arpita Srivastava

currentInstallState is an input.

currentInstallState is an input.

9:23 am

Vendor - TEL - Arpita Srivastava

Do we need doxygen comments for static function declarations? We will have a header in the definition.

Do we need doxygen comments for static function declarations?
We will have a header in the definition.

9:18 am

Vendor - TEL - Arpita Srivastava

AirPump.h should be above AirTrap.h

AirPump.h should be above AirTrap.h

Monday 13 Jul
1:47 pm

Sean Nash

Who is calling this function? Should be coming from UI, right? So should be a message handler (returns BOOL, takes a message as param, function is in table at top of Messaging.c).

Who is calling this function? Should be coming from UI, right? So should be a message handler (returns BOOL, takes a message as param, function is in table at top of Messaging.c).

1:22 pm

Sean Nash

Need to set state to preload state I think. Otherwise you will go to interrupted state.

Need to set state to preload state I think. Otherwise you will go to interrupted state.

12:44 pm

Sean Nash

Why did you remote call to init function here? Is it initialized somewhere else?

Why did you remote call to init function here? Is it initialized somewhere else?

12:41 pm

Sean Nash

Use ternary operation to assign TRUE or FALSE explicitly.

Use ternary operation to assign TRUE or FALSE explicitly.

12:39 pm

Sean Nash

This is at end of enum list above. So it should be at end of table here.

This is at end of enum list above. So it should be at end of table here.

Friday 10 Jul
3:33 pm

Vendor - TEL - Praneeth Bunne

it will be adjusted when I merge latest staging

it will be adjusted when I merge latest staging

3:31 pm

Vendor - TEL - Praneeth Bunne

not required anymore, forgot to remove

not required anymore, forgot to remove

3:21 pm

Sean Nash

I think a comment here is needed. Keep it and maybe mention rinseback alarm responses too.

I think a comment here is needed. Keep it and maybe mention rinseback alarm responses too.

3:20 pm

Sean Nash

Maybe this should be handled in OperationModes exec since it applies to all confirmations (not just alarm related ones).

Maybe this should be handled in OperationModes exec since it applies to all confirmations (not just alarm related ones).

3:19 pm

Sean Nash

There will be confirmations that are not handled here (e.g. power off). So we shouldn't fault in default - we should do nothing.

There will be confirmations that are not handled here (e.g. power off). So we shouldn't fault in default - we should do nothing.

3:17 pm

Sean Nash

Shutdown would be handled somewhere else (buttons.c probably). It's not related to alarms.

Shutdown would be handled somewhere else (buttons.c probably). It's not related to alarms.

3:09 pm

Sean Nash

Is this still possible since we're not returning to TxPaused from rinseback anymore?

Is this still possible since we're not returning to TxPaused from rinseback anymore?

11:17 am

Sean Nash

Is rinseback completed an indication that we've done a blood prime following a temporary break? If so, I guess this makes sense, but we have to do more than increase the UF volume. We have to adjus...

Is rinseback completed an indication that we've done a blood prime following a temporary break?
If so, I guess this makes sense, but we have to do more than increase the UF volume. We have to adjust the UF rate so that we will reach the new (larger) UF volume when the treatment completes.
We also need to add RB volume to UF volume in pre-tx when treatment parameters are given/validated (for the final rinseback which we will always have so we should just plan for it before treatment starts).

11:03 am

Sean Nash

What if multiple confirmations pending? Which ID will this function return?

What if multiple confirmations pending? Which ID will this function return?

10:54 am

Sean Nash

Align comments. Should substitution pump data be moved down to 0xBA instead of commented out?

Align comments.
Should substitution pump data be moved down to 0xBA instead of commented out?

Thursday 09 Jul
2:07 pm

Sean Nash

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

1:36 pm

Sean Nash

Do we really need these setup functions for each state? They all look very simple - just 1 or 2 lines of code.

Do we really need these setup functions for each state? They all look very simple - just 1 or 2 lines of code.