td-firmware / firmware / App / Drivers

BatteryDriver.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 1
Last Commit: 13 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 22 Jun
4:36 pm

Sean Nash

Merge these 3 override functions (and message IDs) into one "array style" override function.

Merge these 3 override functions (and message IDs) into one "array style" override function.

4:07 pm

Sean Nash

( void )

( void )

4:06 pm

Sean Nash

Change 0xFFFFFFFF to HEX_32_BIT_FULL_SCALE

Change 0xFFFFFFFF to HEX_32_BIT_FULL_SCALE

4:04 pm

Sean Nash

Swap the order of these two.

Swap the order of these two.

Saturday 13 Jun
10:11 pm

suresh

LDT-4072: Battery driver and monitor implementation updates

Options
    • -7
    • +5
    ./BatteryDriver.c
  2. … 3 more files in changeset.
Friday 05 Jun
4:14 pm

Sean Nash

Just use 0x0 and 0xFFFFFFFF

Just use 0x0 and 0xFFFFFFFF

4:13 pm

Sean Nash

NUM_OF_BATTERY_REGISTERS - 1

NUM_OF_BATTERY_REGISTERS - 1

4:13 pm

Sean Nash

Put 2 items at end of the list here: BATTERY_END_OF_LIST_TIME_TO_PUBLISH NUM_OF_BATTERY_REGISTERS

Put 2 items at end of the list here:
BATTERY_END_OF_LIST_TIME_TO_PUBLISH
NUM_OF_BATTERY_REGISTERS

4:10 pm

Sean Nash

Put this one back to NUM_OF_BATTERY_DEVICES.

Put this one back to NUM_OF_BATTERY_DEVICES.

4:08 pm

Sean Nash

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

4:04 pm

Sean Nash

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

Saturday 30 May
12:26 pm

suresh

LDT-4072: addressed review comments

Options
    • -9
    • +16
    ./BatteryDriver.c
  2. … 2 more files in changeset.
Wednesday 27 May
5:13 pm

Sean Nash

Not a float.

Not a float.

5:12 pm

Sean Nash

Not a float.

Not a float.

5:12 pm

Sean Nash

Not a float anymore. Use u32Override function and no need to cast the pointer.

Not a float anymore. Use u32Override function and no need to cast the pointer.

5:07 pm

Sean Nash

Should we publish all registers read?

Should we publish all registers read?

5:05 pm

Sean Nash

Remove this comment since we have a comment to right.

Remove this comment since we have a comment to right.

5:04 pm

Sean Nash

Remove comment.

Remove comment.

4:59 pm

Sean Nash

Set them individually instead of with memset.

Set them individually instead of with memset.

4:56 pm

Sean Nash

Add blank line before a /// comment.

Add blank line before a /// comment.

4:55 pm

Sean Nash

device and register is fine. Or deviceSel and registerSel.

device and register is fine. Or deviceSel and registerSel.

Thursday 21 May
1:21 pm

suresh

LDT-4072: code comment updates

Options
    • -20
    • +34
    ./BatteryDriver.c
  2. … 3 more files in changeset.
Wednesday 20 May
10:03 am

Sean Nash

slaveAddr should be an enum now and so just "device".

slaveAddr should be an enum now and so just "device".

9:23 am

suresh

LDT-4072: Address second code review comments

Options
    • -2
    • +2
    ./BatteryDriver.c
  2. … 4 more files in changeset.
9:07 am

Sean Nash

Add a banner before Dialin test support functions (see other units for example).

Add a banner before Dialin test support functions (see other units for example).

9:04 am

Sean Nash

Initialize .override to OVERRIDE_RESET

Initialize .override to OVERRIDE_RESET

9:03 am

Sean Nash

Why is this commented out? Do we not need to initialize it?

Why is this commented out? Do we not need to initialize it?

Tuesday 19 May
9:27 am

Sean Nash

Rename similar to ADDR definitions below. these are not commands.

Rename similar to ADDR definitions below. these are not commands.

9:14 am

Sean Nash

Combine charger and pack data into one payload with one broadcast message.

Combine charger and pack data into one payload with one broadcast message.

9:12 am

Sean Nash

Move these 3 override messages (should end in OVERRIDE_REQUEST) to TD Dialin section below and assign an ID in the 0x8... range.

Move these 3 override messages (should end in OVERRIDE_REQUEST) to TD Dialin section below and assign an ID in the 0x8... range.