td-firmware / firmware / App

Drivers

Clone Tools

Stats

Commits this week: 12
Total Committers: 8
Last Commit: 23 Jul
Commits this week: 12

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 23 Jul
5:57 pm

Vendor - TEL - Varshini Nagabooshanam

Changes

Options
    • -29
    • +35
    ./PinchValve.c
3:45 pm

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'LDT-4149-pinch-valves-fw-implementation' of bitbucket.org:diality-cloud/td-firmware into LDT-4149-pinch-valves-fw-implementation

Options
    • -0
    • +6
    ./PinchValve.c
3:34 pm

Vendor - TEL - Varshini Nagabooshanam

New Add ons

Options
    • -140
    • +266
    ./PinchValve.c
    • -0
    • +3
    ./PinchValve.h
12:56 pm

Sean Nash

LDT-4149: Initialized ABC valve positions array.

Options
    • -0
    • +6
    ./PinchValve.c
11:27 am

Sean Nash

LDT-4149: more changes.

Options
    • -1
    • +24
    ./PinchValve.c
10:39 am

Sean Nash

LDT-4149: More changes.

Options
    • -56
    • +48
    ./PinchValve.c
    • -0
    • +10
    ./PinchValve.h
  3. … 2 more files in changeset.
9:53 am

Vendor - TEL - Varshini Nagabooshanam

Changes

Options
    • -46
    • +116
    ./PinchValve.c
    • -1
    • +10
    ./PinchValve.h
    • -501
    • +0
    ./RotaryValve.c
    • -70
    • +0
    ./RotaryValve.h
  5. … 9 more files in changeset.
9:06 am

Sean Nash

Wednesday 22 Jul
11:32 am

Sean Nash

Swap order of == for these 2 if statements - put constant on left side.

Swap order of == for these 2 if statements - put constant on left side.

11:19 am

Sean Nash

Why?

Why?

11:16 am

Sean Nash

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

11:14 am

Sean Nash

Use ternary operator to explicitly set to TRUE or FALSE.

Use ternary operator to explicitly set to TRUE or FALSE.

9:31 am

Sean Nash

Our TODO comments are all CAPs.

Our TODO comments are all CAPs.

9:25 am

Sean Nash

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

9:21 am

Sean Nash

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

9:19 am

Sean Nash

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

9:18 am

Sean Nash

Should return a BOOL (that is what ModeStandby is expecting).

Should return a BOOL (that is what ModeStandby is expecting).

9:18 am

Sean Nash

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

9:16 am

Sean Nash

Align comment.

Align comment.

9:15 am

Sean Nash

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Tuesday 21 Jul
5:14 pm

Sean Nash

Add comments to right.

Add comments to right.

5:13 pm

Sean Nash

2 blank lines before and after.

2 blank lines before and after.

5:09 pm

Sean Nash

Move declarations into this if scope.

Move declarations into this if scope.

5:08 pm

Sean Nash

Remove blank line.

Remove blank line.

5:07 pm

Sean Nash

Remove (void)

Remove (void)

5:06 pm

Sean Nash

Library includes should come first and they should be in <>. Also add comment listing math functions you're using in this unit.

Library includes should come first and they should be in <>. Also add comment listing math functions you're using in this unit.

9:08 am

Sean Nash

Do we need this?

Do we need this?

9:07 am

Sean Nash

Change this to work for any state (passed as parameter).

Change this to work for any state (passed as parameter).

Monday 20 Jul
5:00 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:33 pm

Sean Nash

Remove

Remove