Activity td-firmware/firmware

Tree
Accordion

Stats

Commits this week: 28

Total Committers:	18
Last Commit:	16:28
Commits this week:	28

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Today

1 hr ago

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-4049-1
finished reviewing

1 hr ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

Can't return in middle of function code.

Can't return in middle of function code.

1 hr ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4063-1
commented on review

Remove else and reject command in it and re-test.

Remove else and reject command in it and re-test.

1 hr ago

Vendor - TEL - Varshini Nagabooshanam

More
aa9f0fe
changed 1 file
LDT-4149-pinch-valves-fw-implementation LEAHI-TD-FIRMWARE-LDT-4149-1

Added doxygen

- -9
- +9
./App/Drivers/PinchValve.h
- History
- Source
- Diff
./App/Drivers/PinchValve.h

1 hr ago

Vendor - TEL - Varshini Nagabooshanam

More
7789bde
changed 1 file
LDT-4149-pinch-valves-fw-implementation LEAHI-TD-FIRMWARE-LDT-4149-1

Added doxygen

- -112
- +112
./App/Drivers/PinchValve.c
- History
- Source
- Diff
./App/Drivers/PinchValve.c

3 hrs ago

Vendor - TEL - Varshini Nagabooshanam

More
4c73839
changed 3 files
LDT-4149-pinch-valves-fw-implementation LEAHI-TD-FIRMWARE-LDT-4149-1

New changes

- -68
- +83
./App/Drivers/PinchValve.c
- History
- Source
- Diff
./App/Drivers/PinchValve.c
- -16
- +18
./App/Drivers/PinchValve.h
- History
- Source
- Diff
./App/Drivers/PinchValve.h
- -4
- +27
./App/Modes/ModeStandby.c
- History
- Source
- Diff
./App/Modes/ModeStandby.c

6 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Changes

- -40
- +84
./App/Drivers/PinchValve.c
- History
- Source
- Diff
./App/Drivers/PinchValve.c
- -1
- +1
./App/Drivers/PinchValve.h
- History
- Source
- Diff
./App/Drivers/PinchValve.h
- -0
- +8
./App/Modes/ModeStandby.c
- History
- Source
- Diff
./App/Modes/ModeStandby.c

Thursday 23 Jul

5:57 pm

Vendor - TEL - Varshini Nagabooshanam

More
1eac37e
changed 1 file
LDT-4149-pinch-valves-fw-implementation LEAHI-TD-FIRMWARE-LDT-4149-1

Changes

- -29
- +35
./App/Drivers/PinchValve.c
- History
- Source
- Diff
./App/Drivers/PinchValve.c

3:45 pm

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'LDT-4149-pinch-valves-fw-implementation' of bitbucket.org:diality-cloud/td-firmware into LDT-4149-pinch-valves-fw-implementation

- -0
- +6
./App/Drivers/PinchValve.c
- History
- Source
- Diff
./App/Drivers/PinchValve.c

3:34 pm

Vendor - TEL - Varshini Nagabooshanam

More
0706d11
changed 2 files
LDT-4149-pinch-valves-fw-implementation LEAHI-TD-FIRMWARE-LDT-4149-1

New Add ons

- -140
- +266
./App/Drivers/PinchValve.c
- History
- Source
- Diff
./App/Drivers/PinchValve.c
- -0
- +3
./App/Drivers/PinchValve.h
- History
- Source
- Diff
./App/Drivers/PinchValve.h

12:56 pm

Sean Nash

More
71e6f49
changed 1 file
LDT-4149-pinch-valves-fw-implementation LEAHI-TD-FIRMWARE-LDT-4149-1

LDT-4149: Initialized ABC valve positions array.

- -0
- +6
./App/Drivers/PinchValve.c
- History
- Source
- Diff
./App/Drivers/PinchValve.c

11:48 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

11:48 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

recircPublishTimerCtr is an output

recircPublishTimerCtr is an output

11:46 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Add @message MSG_ID_TD_RECIRCULATE_RESPONSE

Add @message MSG_ID_TD_RECIRCULATE_RESPONSE

11:44 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

11:40 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Initialization missing for the following variables in the init function. startRecircRequested reconnectRequested backToTreatmentRequested resumeRecircRequested

Initialization missing for the following variables in the init function.

startRecircRequested
reconnectRequested
backToTreatmentRequested
resumeRecircRequested

11:32 am

Vendor - TEL - Praneeth Bunne

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
replied to Vendor - TEL - Arpita Srivastava

All signal flags are initialized in resetSignalFlags() which we are calling below

All signal flags are initialized in resetSignalFlags() which we are calling below

11:27 am

Sean Nash

LDT-4149: more changes.

- -1
- +24
./App/Drivers/PinchValve.c
- History
- Source
- Diff
./App/Drivers/PinchValve.c

11:23 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

please update the alarm id reservation sheet.

please update the alarm id reservation sheet.

11:20 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Why is MSG_ID_DD_SUBSTITUTION_PUMP_DATA commented out? Line 214 and 215 are using tabs instead of whitespace characters because of which the alignment is off.

Why is MSG_ID_DD_SUBSTITUTION_PUMP_DATA commented out?
Line 214 and 215 are using tabs instead of whitespace characters because of which the alignment is off.

11:15 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line : one variable per line will be easy to read.

break this line : one variable per line will be easy to read.

11:13 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

StateTxRecirc should be above StateTxRinseback

StateTxRecirc should be above StateTxRinseback

11:07 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Add @Alarm ALARM_ID_TD_SALINE_BAG_VOLUME_LOW_ALARM

Add @Alarm ALARM_ID_TD_SALINE_BAG_VOLUME_LOW_ALARM

11:05 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

11:05 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

11:04 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Add rinsebackPublishTimerCtr to outputs

Add rinsebackPublishTimerCtr to outputs

10:55 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

add rinsebackPublishTimerCtr to outputs

add rinsebackPublishTimerCtr to outputs

10:55 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

10:55 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

add rinsebackPublishTimerCtr to outputs

add rinsebackPublishTimerCtr to outputs

10:54 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-07-24 18:20 -0700