td-firmware

Clone Tools

Stats

Commits this week: 23
Total Committers: 15
Last Commit: 29 Apr
Commits this week: 23

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Apr
5:55 pm

Michael Garthwaite

3:57 pm

Sean Nash

I don't think you want stored (old) value here. You want value from first message before confirmation.

I don't think you want stored (old) value here. You want value from first message before confirmation.

1:41 pm

Sean Nash

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert ...

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert to L/hr every time it needs to send UI a message. Either way works for me.

12:21 pm

Raghu Kallala

Changed to U32

Changed to U32

12:21 pm

Raghu Kallala

we are sending a message ack as response in the handler of this message request

we are sending a message ack as response in the handler of this message request

11:53 am

Raghu Kallala

Other existing set functions in TD is using UF in liter and rate in L/hr Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

Other existing set functions in TD is using UF in liter and rate in L/hr

Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

11:21 am

Michael Garthwaite and Vinayakam Mani

11:10 am

Sean Nash

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When se...

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When sending UF rate to UI, we would convert back to L/hr first, but everywhere else we would work with mL/min.

11:01 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:00 am

Sean Nash

Remove extra space before function name.

Remove extra space before function name.

11:00 am

Sean Nash

This is not a Dialin message, so move up above all of these "test" functions.

This is not a Dialin message, so move up above all of these "test" functions.

10:59 am

Sean Nash

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate dox...

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate doxygen group.

9:55 am

Vinayakam Mani

Do we have a return confirmation that the command is accepted by DD?

Do we have a return confirmation that the command is accepted by DD?

9:45 am

Vinayakam Mani

Is the UF rate unit in ml/min (instead of hr.)?

Is the UF rate unit in ml/min (instead of hr.)?

9:36 am

Vinayakam Mani

Are we assuming the sub mode return is pre-gen sub mode always?

Are we assuming the sub mode return is pre-gen sub mode always?

8:41 am

Michael Garthwaite

create the getDialGoodToDeliverStatus() function and have that return true rather than have the assignment here

create the getDialGoodToDeliverStatus() function and have that return true rather than have the assignment here

8:37 am

Michael Garthwaite

comment still needed?

comment still needed?

Wednesday 29 Apr
2:01 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI
LEAHI-TD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI
11:02 am

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/TDCommon.h
11:02 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /firmware/App/Modes/ModeStandby.c
    • -2
    • +2
    /firmware/App/Modes/ModeTreatment.c
    • -2
    • +2
    /firmware/App/Modes/ModeTreatment.h
    • -2
    • +2
    /firmware/App/Modes/StateTxDialysis.c
    • -2
    • +2
    /firmware/App/Monitors/Pressures.c
    • -2
    • +2
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -2
    • +2
    /firmware/App/Services/DDInterface.c
    • -2
    • +2
    /firmware/App/Services/DDInterface.h
    • -2
    • +2
    /firmware/App/Services/Messaging.c
    • -2
    • +2
    /firmware/App/Services/TxParams.c
    • -2
    • +2
    /firmware/App/Services/TxParams.h
    • -2
    • +2
    /firmware/App/TDCommon.h
10:59 am

Raghu Kallala

LDT-473 merge latest into staging

Options
10:57 am

Raghu Kallala

LDT-473 resolved merge conflicts with staging

Options
    • -3
    • +4
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -1
    • +1
    /firmware/App/TDCommon.h
10:57 am

Raghu Kallala

10:44 am

Vinayakam Mani

9:57 am

Sean Nash

Keep 2 blank lines above the banner below.

Keep 2 blank lines above the banner below.

9:56 am

Sean Nash

Is this still needed?

Is this still needed?

9:56 am

Sean Nash

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

9:49 am

Sean Nash

Keep 2 blank lines above the test support functions banner.

Keep 2 blank lines above the test support functions banner.

9:47 am

Sean Nash

Not sure why you are making changes to this function. This function handles message from UI to pause or resume ultrafiltration. This is not a treatment parameter edit message, so I don't think it's...

Not sure why you are making changes to this function.
This function handles message from UI to pause or resume ultrafiltration.
This is not a treatment parameter edit message, so I don't think it's part of your assignment.

9:43 am

Sean Nash

No longer needed?

No longer needed?