td-firmware / firmware / App / Services

StateServices

Clone Tools

Stats

Commits this week: 2
Total Committers: 3
Last Commit: 29 May
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 03 Jun
9:51 am

Sean Nash

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD...

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD or HDF type). Then when we get this response msg from UI, we will compare the type to the user selected modality (from TxParams) to see if it matches.

9:48 am

Sean Nash

Add doxygen comments to the right of each structure field.

Add doxygen comments to the right of each structure field.

9:47 am

Sean Nash

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

9:46 am

Sean Nash

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).

9:44 am

Sean Nash

For now, we need to set barcodeScanResponseReceived to TRUE here until barcode scan command is implemented.

For now, we need to set barcodeScanResponseReceived to TRUE here until barcode scan command is implemented.

9:29 am

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

9:29 am

Sean Nash

Keep this blank line above group header.

Keep this blank line above group header.

9:28 am

Sean Nash

Something is wrong here. We already had reg 33 at line 192 above. Reconcile with HDD.

Something is wrong here. We already had reg 33 at line 192 above. Reconcile with HDD.

Friday 22 May
3:39 pm

Vendor - TEL - Praneeth Bunne

1:31 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

11:47 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -3
    • +3
    ./TubeSetAutoEject.c
    • -3
    • +3
    ./TubeSetAutoEject.h
    • -3
    • +3
    ./TubeSetInstall.c
    • -3
    • +3
    ./TubeSetInstall.h
  5. … 11 more files in changeset.
Thursday 21 May
11:16 am

Vendor - TEL - Praneeth Bunne

LDT-1886: Update event related code

Options
    • -10
    • +11
    ./TubeSetAutoEject.c
    • -10
    • +11
    ./TubeSetInstall.c
Wednesday 20 May
3:49 pm

Vendor - TEL - Arpita Srivastava

We can rename priorState to previousInstallState. Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

We can rename priorState to previousInstallState.
Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

3:45 pm

Vendor - TEL - Praneeth Bunne

LDT-1886: Add send event

Options
    • -0
    • +7
    ./TubeSetAutoEject.c
    • -0
    • +7
    ./TubeSetInstall.c
Tuesday 19 May
5:39 pm

Sean Nash

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

5:37 pm

Sean Nash

Remove this blank line.

Remove this blank line.

3:37 pm

Vendor - TEL - Arpita Srivastava

There is still merge conflict? Please resolve merge conflict and build the code in your local before pushing.

There is still merge conflict?
Please resolve merge conflict and build the code in your local before pushing.

3:35 pm

Sean Nash

This merge conflict is still unresolved.

This merge conflict is still unresolved.

3:35 pm

Vendor - TEL - Arpita Srivastava

leak in the comment section.

leak in the comment section.

3:34 pm

Sean Nash

Where is alarm 191..203?

Where is alarm 191..203?

Monday 18 May
10:47 am

Vendor - TEL - Praneeth Bunne

LDT-1886: Update doxygen stuff

Options
    • -2
    • +2
    ./TubeSetAutoEject.c
    • -2
    • +2
    ./TubeSetInstall.c
9:45 am

Vendor - TEL - Arpita Srivastava

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

9:44 am

Vendor - TEL - Arpita Srivastava

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

Friday 15 May
3:30 pm

Vendor - TEL - Praneeth Bunne

LDT-1886: Refactor tube set jam logic

Options
    • -12
    • +19
    ./TubeSetAutoEject.c
    • -14
    • +21
    ./TubeSetInstall.c
  3. … 1 more file in changeset.
11:30 am

Vendor - TEL - Praneeth Bunne

LDT-1886: Update alarm name blood tube set failure

Options
    • -4
    • +4
    ./TubeSetAutoEject.c
    • -3
    • +3
    ./TubeSetInstall.c
11:02 am

Vendor - TEL - Praneeth Bunne

LDT-1886: Remove backOffAfterRetract variable and update brief

Options
    • -11
    • +15
    ./TubeSetAutoEject.c
  2. … 1 more file in changeset.
9:52 am

Vendor - TEL - Varshini Nagabooshanam

I missed updating this earlier, I’ll push the updated code.

I missed updating this earlier, I’ll push the updated code.

9:19 am

Sean Nash

Can't have 3 values. Maximum 2 values allowed.

Can't have 3 values. Maximum 2 values allowed.

Wednesday 13 May
10:48 am

Vendor - TEL - Varshini Nagabooshanam

Removedd

Removedd

10:44 am

Vendor - TEL - Varshini Nagabooshanam

added

added