Drivers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Our TODO comments are all CAPs.

Our TODO comments are all CAPs.

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

Should return a BOOL (that is what ModeStandby is expecting).

Should return a BOOL (that is what ModeStandby is expecting).

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

Align comment.

Align comment.

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Add comments to right.

Add comments to right.

2 blank lines before and after.

2 blank lines before and after.

Move declarations into this if scope.

Move declarations into this if scope.

Remove blank line.

Remove blank line.

Remove (void)

Remove (void)

Library includes should come first and they should be in <>. Also add comment listing math functions you're using in this unit.

Library includes should come first and they should be in <>. Also add comment listing math functions you're using in this unit.

Do we need this?

Do we need this?

Change this to work for any state (passed as parameter).

Change this to work for any state (passed as parameter).

Fixed

Fixed

Remove

Remove

Alphabetize these includes.

Alphabetize these includes.

Why is this commented out?

Why is this commented out?

Don't need yet.

Don't need yet.

Remove all cleaning related functions.

Remove all cleaning related functions.

Don't need this yet.

Don't need this yet.

Remove for now.

Remove for now.

Missing a comment.

Missing a comment.

Remove last 5 messages.

Remove last 5 messages.

Remove these. These are Denali modes.

Remove these. These are Denali modes.

Remove these for now.

Remove these for now.

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before en...

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before entering Pre-Treatment.

Changes

  1. … 1 more file in changeset.