td-firmware / firmware / App / Services

StateServices

Clone Tools

Stats

Commits this week: 4
Total Committers: 5
Last Commit: 20 Jul
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 hrs ago

Sean Nash

Should this be the "Load Syringe" alarm that you just added? Also, does this alarm show the user how much heparin to load into the syringe? I wasn't expecting this to be an alarm.

Should this be the "Load Syringe" alarm that you just added?
Also, does this alarm show the user how much heparin to load into the syringe? I wasn't expecting this to be an alarm.

2 hrs ago

Sean Nash

Can we remote this TODO comment?

Can we remote this TODO comment?

2 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

2 hrs ago

Sean Nash

We should go to dry self test state. Why did this change to Rx state?

We should go to dry self test state. Why did this change to Rx state?

2 hrs ago

Sean Nash

Comment - should be "install" not "instll".

Comment - should be "install" not "instll".

3 hrs ago

Vendor - TEL - Vijay Pamula

Monday 20 Jul
5:00 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

Thursday 16 Jul
1:20 pm

Michael Garthwaite

LDT-4611: HDF state machine implementation plus calls to controller

Options
    • -0
    • +2
    ./TubeSetInstall.c
  2. … 7 more files in changeset.
Wednesday 15 Jul
3:03 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-TD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
11:59 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./TubeSetInstall.c
    • -2
    • +2
    ./TubeSetInstall.h
  3. … 7 more files in changeset.
9:15 am

Vendor - TEL - Arpita Srivastava

Tuesday 14 Jul
11:17 pm

Sean Nash

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmatio...

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmation msg is received.

11:10 pm

Sean Nash

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

5:55 pm

Sean Nash

5:53 pm

Sean Nash

171

171

10:18 am

Vendor - TEL - Vijay Pamula

LDT-4028: Addressed Review Commentsfor Install state

Options
    • -7
    • +7
    ./TubeSetInstall.c
  2. … 1 more file in changeset.
9:39 am

Sean Nash

Update all function headers in this file to Leahi style (e.g. \b before inputs/outputs).

Update all function headers in this file to Leahi style (e.g. \b before inputs/outputs).

9:38 am

Sean Nash

Add extra line (should be 2 lines) after test support banner.

Add extra line (should be 2 lines) after test support banner.

9:36 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:35 am

Sean Nash

Update function header format from Denali to Leahi style (e.g. \b for inputs/outputs) throughout this file.

Update function header format from Denali to Leahi style (e.g. \b for inputs/outputs) throughout this file.

9:26 am

Vendor - TEL - Arpita Srivastava

currentInstallState is an input.

currentInstallState is an input.

9:23 am

Vendor - TEL - Arpita Srivastava

Do we need doxygen comments for static function declarations? We will have a header in the definition.

Do we need doxygen comments for static function declarations?
We will have a header in the definition.

9:18 am

Vendor - TEL - Arpita Srivastava

AirPump.h should be above AirTrap.h

AirPump.h should be above AirTrap.h

Monday 13 Jul
1:47 pm

Sean Nash

Who is calling this function? Should be coming from UI, right? So should be a message handler (returns BOOL, takes a message as param, function is in table at top of Messaging.c).

Who is calling this function? Should be coming from UI, right? So should be a message handler (returns BOOL, takes a message as param, function is in table at top of Messaging.c).

1:22 pm

Sean Nash

Need to set state to preload state I think. Otherwise you will go to interrupted state.

Need to set state to preload state I think. Otherwise you will go to interrupted state.

12:44 pm

Sean Nash

Why did you remote call to init function here? Is it initialized somewhere else?

Why did you remote call to init function here? Is it initialized somewhere else?

12:41 pm

Sean Nash

Use ternary operation to assign TRUE or FALSE explicitly.

Use ternary operation to assign TRUE or FALSE explicitly.

12:39 pm

Sean Nash

This is at end of enum list above. So it should be at end of table here.

This is at end of enum list above. So it should be at end of table here.

Friday 10 Jul
3:33 pm

Vendor - TEL - Praneeth Bunne

it will be adjusted when I merge latest staging

it will be adjusted when I merge latest staging

3:31 pm

Vendor - TEL - Praneeth Bunne

not required anymore, forgot to remove

not required anymore, forgot to remove