Activity td-firmware/firmware/App/Services

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before en...

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before entering Pre-Treatment.

1:20 pm

Michael Garthwaite

More
8acb1d0
changed 8 files
LDT-4611-hdf-fw-implementation-5-4 LEAHI-TD-FIRMWARE-LDT-4611-4

LDT-4611: HDF state machine implementation plus calls to controller

- -1
- +2
./AlarmMgmtSWFaults.h
- History
- Source
- Diff
./AlarmMgmtSWFaults.h
- -0
- +5
./Messaging.c
- History
- Source
- Diff
./Messaging.c
- -0
- +2
./StateServices/TubeSetInstall.c
- History
- Source
- Diff
./StateServices/TubeSetInstall.c
… 5 more files in changeset.

9:14 am

Michael Garthwaite

More
bbd48b0
changed 5 files
LDT-4611-hdf-fw-implementation-5-4 LEAHI-TD-FIRMWARE-LDT-4611-4

Merge branch 'LDT-4003-hdf-fw-implementation-4-4' into LDT-4611-hdf-fw-implementation-5-4

- -0
- +1
./AlarmMgmtSWFaults.h
- History
- Source
- Diff
./AlarmMgmtSWFaults.h
- -2
- +40
./DDInterface.c
- History
- Source
- Diff
./DDInterface.c
… 3 more files in changeset.

3:03 pm

Dara Navaei

More
LEAHI-TD-FIRMWARE-LDT-4611-4
started review

LEAHI-TD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:

11:59 am

Dara Navaei

More
8331042
changed 9 files
LDT-3992-disposable-tube-set-auto-priming, LDT-4009-isolated-uf-td and 7 more LEAHI-TD-FIRMWARE-LDT-4009-1 LEAHI-TD-FIRMWARE-LDT-4029-1 LEAHI-TD-FIRMWARE-LDT-4149-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./Messaging.c
- History
- Source
- Diff
./Messaging.c
- -2
- +2
./StateServices/TubeSetInstall.c
- History
- Source
- Diff
./StateServices/TubeSetInstall.c
- -2
- +2
./StateServices/TubeSetInstall.h
- History
- Source
- Diff
./StateServices/TubeSetInstall.h
- -2
- +2
./TxParams.c
- History
- Source
- Diff
./TxParams.c
- -1
- +1
./TxParams.h
- History
- Source
- Diff
./TxParams.h
… 4 more files in changeset.

9:15 am

Vendor - TEL - Arpita Srivastava

More
LEAHI-TD-FIRMWARE-LDT-4028-2
finished reviewing

11:17 pm

Sean Nash

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmatio...

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmation msg is received.

11:10 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4029-1
commented on review

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

5:55 pm