leahi-fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
its auto generated . should not change it manually. any way when merging its added correct value

its auto generated . should not change it manually. any way when merging its added correct value

Now we don't need this macro ?

Now we don't need this macro ?

now we are initializing sensor simultaneously?

now we are initializing sensor simultaneously?

comments missing

comments missing

comments missing

comments missing

This is not clear- please give a detailed description for this variable

This is not clear- please give a detailed description for this variable

use capital for starting letter

use capital for starting letter

please align the comments

please align the comments

please Alignment the comments

please Alignment the comments

Why the order is important here ? please document it

Why the order is important here ? please document it

do we need bracket here ? all text should start with capital

do we need bracket here ? all text should start with capital

Why a * here ?

Why a * here ?

is it write states or read state ?

is it write states or read state ?

is documentation correct ?

is documentation correct ?

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Add blank line before return.

Add blank line before return.

Add blank line before return.

Add blank line before return.

Remove blank line.

Remove blank line.

From what I see in UI, it is just a range value not an enum/index

From what I see in UI, it is just a range value not an enum/index

Is it an enum/index like Denali then?

Is it an enum/index like Denali then?

No we are not getting conv factor from UI on it I will have to confirm with Nick to see if we will get the bicarbConvFactor

No we are not getting conv factor from UI on it
I will have to confirm with Nick to see if we will get the bicarbConvFactor