leahi-dialin

leahi_dialin

Clone Tools

Stats

Commits this week: 46
Total Committers: 16
Last Commit: 13:29
Commits this week: 46

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
4 hrs ago

Behrouz NematiPour

I am happy to see that this old code is improving. I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically. Examples can be found in t...

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

5 hrs ago

Behrouz NematiPour

Please add a docstring for the function. including the intention and parameters with their intentions.

Please add a docstring for the function.
including the intention and parameters with their intentions.

5 hrs ago

Behrouz NematiPour

Same for CanChannels. The Channels we are referring to here are Leahi's or Denali's. Channels mainly have no meaning beyond their priorities when a collision occurs.

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

5 hrs ago

Behrouz NematiPour

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending. I'm not sure why the name was...

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

5 hrs ago

Dara Navaei

LEAHI-DIALIN-LDT-4072_Power Loss - FW Implementation - 2/3:
LEAHI-DIALIN-LDT-4072_Power Loss - FW Implementation - 2/3:
6 hrs ago

Vendor - TEL - Sameer Poyil

6 hrs ago

Zoltan Miskolci

6 hrs ago

Zoltan Miskolci

7 hrs ago

Nicholas Ramirez

change to td_powerOff_wARNING

change to td_powerOff_wARNING

7 hrs ago

Behrouz NematiPour

9 hrs ago

Michael Garthwaite

LDt-4733: fixed typo in voltage module

Options
    • -2
    • +2
    ./dd/modules/voltages.py
11 hrs ago

Zoltan Miskolci

Could you just leave it as or TBD_B7 = 0xB7 ? So it will be easy to see that the msg id location is free to use

Could you just leave it as or TBD_B7 = 0xB7 ?
So it will be easy to see that the msg id location is free to use

11 hrs ago

Michael Garthwaite

LDT-4733: voltage monitoring updates.

Options
    • -1
    • +9
    ./common/dd_defs.py
    • -9
    • +17
    ./dd/modules/voltages.py
13 hrs ago

Dara Navaei

LEAHI-DIALIN-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data
LEAHI-DIALIN-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data
Wednesday 24 Jun
9:23 pm

Vinayakam Mani

2:56 pm

Vinayakam Mani

Update the name.

Update the name.

2:39 pm

Vendor - TEL - Sameer Poyil

Tuesday 23 Jun
3:10 pm

Nicholas Ramirez

10:40 am

Zoltan Miskolci

updated

updated

10:32 am

Raghu Kallala

Remove extra spaces before comment

Remove extra spaces before comment

9:53 am

Tiffany Mejia and Behrouz NematiPour

9:49 am

Dara Navaei

LEAHI-DIALIN-LDT-4787_NON-FEATURE: SW Misc & Enhc - SW - 01 - Power Control - Shutdown - R&I
LEAHI-DIALIN-LDT-4787_NON-FEATURE: SW Misc & Enhc - SW - 01 - Power Control - Shutdown - R&I
9:36 am

Nicholas Ramirez

9:36 am

Nicholas Ramirez

9:36 am

Nicholas Ramirez

9:35 am

Nicholas Ramirez

9:19 am

Dara Navaei

LDT-4747: SW Integration - FP Diagnostics - DialIn
LDT-4747: SW Integration - FP Diagnostics - DialIn
Monday 22 Jun
3:50 pm

Zoltan Miskolci

fix msg_id

Options
    • -2
    • +2
    ./common/msg_ids.py
3:34 pm

Zoltan Miskolci

fix msg_ids

Options
    • -0
    • +19
    ./common/msg_ids.py
2:55 pm

Zoltan Miskolci