leahi-dialin / leahi_dialin

dd

Clone Tools

Stats

Commits this week: 25
Total Committers: 13
Last Commit: 25 Jun
Commits this week: 25

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Jun
5:33 pm

Behrouz NematiPour

I am happy to see that this old code is improving. I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically. Examples can be found in t...

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

5:19 pm

Behrouz NematiPour

Please add a docstring for the function. including the intention and parameters with their intentions.

Please add a docstring for the function.
including the intention and parameters with their intentions.

5:17 pm

Behrouz NematiPour

Same for CanChannels. The Channels we are referring to here are Leahi's or Denali's. Channels mainly have no meaning beyond their priorities when a collision occurs.

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

5:15 pm

Behrouz NematiPour

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending. I'm not sure why the name was...

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

4:13 pm

Vendor - TEL - Sameer Poyil

4:13 pm

Zoltan Miskolci

4:07 pm

Zoltan Miskolci

1:29 pm

Michael Garthwaite

LDt-4733: fixed typo in voltage module

Options
    • -2
    • +2
    ./modules/voltages.py
10:41 am

Michael Garthwaite

LDT-4733: voltage monitoring updates.

Options
    • -9
    • +17
    ./modules/voltages.py
  2. … 1 more file in changeset.
8:47 am

Dara Navaei

LEAHI-DIALIN-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data
LEAHI-DIALIN-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data
Wednesday 24 Jun
9:23 pm

Vinayakam Mani

2:56 pm

Vinayakam Mani

Update the name.

Update the name.

2:39 pm

Vendor - TEL - Sameer Poyil

Tuesday 23 Jun
10:40 am

Zoltan Miskolci

updated

updated

10:32 am

Raghu Kallala

Remove extra spaces before comment

Remove extra spaces before comment

Monday 22 Jun
2:55 pm

Zoltan Miskolci

1:00 pm

Vinayakam Mani and Michael Garthwaite

Thursday 18 Jun
4:34 pm

Zoltan Miskolci

Please consult the FW-SW integration xls file for MSG_ID reservations. Please add the ones you need to that list as without missing any reservations for IDs the randomly added IDs will be overwritt...

Please consult the FW-SW integration xls file for MSG_ID reservations.
Please add the ones you need to that list as without missing any reservations for IDs the randomly added IDs will be overwritten by reserved ones.

2:36 pm

Zoltan Miskolci

If it's mixing control, then rename the parameters to reflect it, these names suggest a different module

If it's mixing control, then rename the parameters to reflect it, these names suggest a different module

2:35 pm

Zoltan Miskolci

Fix Spacing please to be consistent with the rest of the variables

Fix Spacing please to be consistent with the rest of the variables

2:34 pm

Zoltan Miskolci

Please maintain the FW-SW Integration.xlsx for MSG_ID reservation. Meaning, add these there too to avoid overwriting or deleting them

Please maintain the FW-SW Integration.xlsx for MSG_ID reservation.
Meaning, add these there too to avoid overwriting or deleting them

9:40 am

Michael Garthwaite

Instead of removing, could you move them to the bottom of the list to prevent exceptions being thrown?

Instead of removing, could you move them to the bottom of the list to prevent exceptions being thrown?

9:17 am

Dara Navaei

LEAHI-DIALIN-LDT-4732_(Dialin) Dialin version should be included in the all system logs
LEAHI-DIALIN-LDT-4732_(Dialin) Dialin version should be included in the all system logs
Wednesday 17 Jun
6:48 pm

Dara Navaei

LEAHI-DIALIN-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
LEAHI-DIALIN-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
2:25 pm

Zoltan Miskolci

Updated msg IDs Updated version handling

Options
    • -30
    • +2
    ./dialysate_delivery.py
  2. … 3 more files in changeset.
Tuesday 16 Jun
10:56 am

Michael Garthwaite

10:44 am

Vinayakam Mani and Zoltan Miskolci

10:26 am

Michael Garthwaite

LDT-4485: updates to msg id list. creation of version and calibration request commands

Options
    • -0
    • +73
    ./modules/conductivity_sensors.py
  2. … 1 more file in changeset.
10:08 am

Vinayakam Mani and Zoltan Miskolci

9:53 am

Zoltan Miskolci