Pressures.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
currentInstallState is an input.

currentInstallState is an input.

Do we need doxygen comments for static function declarations? We will have a header in the definition.

Do we need doxygen comments for static function declarations?
We will have a header in the definition.

AirPump.h should be above AirTrap.h

AirPump.h should be above AirTrap.h

Remove extra ;

Remove extra ;

Can we align comments?

Can we align comments?

Missing pinch valves (H1 and H19).

Missing pinch valves (H1 and H19).

Remove this blank line.

Remove this blank line.

please add message id.

please add message id.

We should set all TD actuators here, not just blood pump.

We should set all TD actuators here, not just blood pump.

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

Change "SetupConnection" to "SetupTubingSetConnection"

Change "SetupConnection" to "SetupTubingSetConnection"

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

LEAHI-TD-FIRMWARE-LDT-4028_Pre-Treatment - FW Implementation - 3/6:
LEAHI-TD-FIRMWARE-LDT-4028_Pre-Treatment - FW Implementation - 3/6:
No, Fixed

No, Fixed

I don't think you should be subtracting venMinOffset anymore. Check with Eliza.

I don't think you should be subtracting venMinOffset anymore. Check with Eliza.

LEAHI-TD-FIRMWARE-LDT-4094_Pressures Monitoring - FW Iteration - 1/1:
LEAHI-TD-FIRMWARE-LDT-4094_Pressures Monitoring - FW Iteration - 1/1:
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 8 more files in changeset.
LDT-3970: Addressed review comments for edit treatment parameters

Please add the min and max for tmp as well in the outputs.

Please add the min and max for tmp as well in the outputs.

Merge branch 'staging' into LDT-3970-edit-treatment-parameters-during-treatment

  1. … 2 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 7 more files in changeset.
Done

Done