dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 22
Total Committers: 18
Last Commit: 15 Jul
Commits this week: 22

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 15 Jul
9:57 am

Vendor - TEL - Arpita Srivastava

Merge branch 'LDT-3735-non-volatile-memory' of bitbucket.org:diality-cloud/dd-firmware into LDT-5157-conductivity-sensor-calibration

Options
    • -1
    • +1
    ./Monitors/Voltages.c
    • -1
    • +2
    ./Tasks/TaskGeneral.c
9:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
9:33 am

Vendor - TEL - Arpita Srivastava

LDT-3735: Addressed review comments

Options
    • -15
    • +15
    ./Services/Messaging.c
    • -83
    • +116
    ./Services/NVMessagingDD.c
    • -17
    • +15
    ./Services/NVMessagingDD.h
    • -2
    • +1
    ./Services/NVRecordsDD.c
    • -1
    • +1
    ./Services/NVRecordsDD.h
Tuesday 14 Jul
3:07 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
3:06 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Drivers/ConductivitySensors.c
    • -1
    • +1
    ./Drivers/ConductivitySensors.h
    • -2
    • +2
    ./Monitors/Conductivity.c
    • -1
    • +1
    ./Monitors/Conductivity.h
    • -2
    • +2
    ./Monitors/Voltages.c
    • -2
    • +2
    ./Monitors/Voltages.h
    • -1
    • +1
    ./Services/FpgaDD.c
    • -1
    • +1
    ./Services/FpgaDD.h
    • -2
    • +2
    ./Tasks/TaskGeneral.c
3:02 pm

Michael Garthwaite

LDT-4733: fixed warning of implicit call

Options
    • -0
    • +1
    ./Tasks/TaskGeneral.c
2:58 pm

Michael Garthwaite

2:58 pm

Michael Garthwaite

2:43 pm

Sean Nash

Remove blank line.

Remove blank line.

2:42 pm

Sean Nash

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

2:37 pm

Sean Nash

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

2:32 pm

Sean Nash

Add blank line between declarations and rest of function code (throughout this unit)

Add blank line between declarations and rest of function code (throughout this unit)

2:31 pm

Sean Nash

Add blank line before return statement. ( throughout this unit )

Add blank line before return statement. ( throughout this unit )

2:31 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

2:30 pm

Sean Nash

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:30 pm

Sean Nash

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:30 pm

Sean Nash

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:30 pm

Sean Nash

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:29 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

2:29 pm

Sean Nash

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:29 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

2:29 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

2:28 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

2:28 pm

Sean Nash

Indent too deep here.

Indent too deep here.

2:27 pm

Sean Nash

Remove blank line.

Remove blank line.

2:26 pm

Sean Nash

Indent looks too deep here.

Indent looks too deep here.

2:25 pm

Sean Nash

1 blank line here is sufficient.

1 blank line here is sufficient.

1:30 pm

Sean Nash

Remove blank line.

Remove blank line.

1:29 pm

Sean Nash

Remove blank line.

Remove blank line.

1:29 pm

Sean Nash

Remove blank line.

Remove blank line.