td-firmware / firmware / App / Services

DDInterface.c

Clone Tools

Stats

Commits this week: 4
Total Committers: 10
Last Commit: 13 Aug
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
36 mins ago

Sean Nash

1 hr ago

Sean Nash

Should be only one return at end of function.

Should be only one return at end of function.

1 hr ago

Sean Nash

I think != TRUE is better in these cases.

I think != TRUE is better in these cases.

1 hr ago

Sean Nash

Should be "brief". No "s".

Should be "brief". No "s".

Friday 14 Aug
1:03 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-5363_Pre-Treatment - FW Implementation - 11/6:
LEAHI-TD-FIRMWARE-LDT-5363_Pre-Treatment - FW Implementation - 11/6:
12:31 pm

Sean Nash

Not needed? Add another BOOL for disinfection option received.

Not needed? Add another BOOL for disinfection option received.

12:23 pm

Sean Nash

Initialize this.

Initialize this.

12:15 pm

Sean Nash

Remove TODO

Remove TODO

12:14 pm

Sean Nash

Remove disable of ejector motor.

Remove disable of ejector motor.

12:09 pm

Sean Nash

Remove RotaryValve.h. It's obsolete and we should be using higher level controller Valves.h anyway.

Remove RotaryValve.h. It's obsolete and we should be using higher level controller Valves.h anyway.

12:07 pm

Sean Nash

Just move msg handlers from Messaging to here so you don't need a signal.

Just move msg handlers from Messaging to here so you don't need a signal.

12:06 pm

Sean Nash

Move to .c file to make private.

Move to .c file to make private.

12:05 pm

Sean Nash

Not needed.

Not needed.

11:18 am

Sean Nash

Do we need summary review msgs? 0xA9 and 0xAA cover request for summary data.

Do we need summary review msgs? 0xA9 and 0xAA cover request for summary data.

11:16 am

Sean Nash

Missing heat citric

Missing heat citric

11:09 am

Sean Nash

Put back to reserved

Put back to reserved

Thursday 13 Aug
11:08 am

Sean Nash

Shouldn't this be in ModePostTreatment?

Shouldn't this be in ModePostTreatment?

11:06 am

Sean Nash

void cmdStartDDDisinfection( DD_COMMAND_T disCmdType )

void cmdStartDDDisinfection( DD_COMMAND_T disCmdType )

10:58 am

Sean Nash

Update this to work for all standby states w/ switch statement on given "new" state.

Update this to work for all standby states w/ switch statement on given "new" state.

10:32 am

Sean Nash

Why zeroes? Why not send TD version constants?

Why zeroes? Why not send TD version constants?

10:22 am

Sean Nash

Add parameter (disinfection cmd enum from DDDefs.h). Then only need one signal function for all disinfection types.

Add parameter (disinfection cmd enum from DDDefs.h). Then only need one signal function for all disinfection types.

10:16 am

Sean Nash

change enum name too. need 1 alarm for each disinfection type.

change enum name too. need 1 alarm for each disinfection type.

10:14 am

Sean Nash

Just do one dd disinfect request msg with a command ID payload (from enum in DDDefs.h).

Just do one dd disinfect request msg with a command ID payload (from enum in DDDefs.h).

10:06 am

Sean Nash

Missing some disinfects.

Missing some disinfects.

10:05 am

Sean Nash

Move up after HCOL

Move up after HCOL

Wednesday 12 Aug
10:11 am

Sean Nash

Is this still necessary? Comment out before merging to staging.

Is this still necessary? Comment out before merging to staging.

10:10 am

Sean Nash

Why are registers being repeated? Sync w/ latest HDD.

Why are registers being repeated? Sync w/ latest HDD.

10:08 am

Sean Nash

Can we remove this commented out line of code?

Can we remove this commented out line of code?

10:07 am

Sean Nash

Why is this commented out?

Why is this commented out?

10:05 am

Sean Nash

Why is state transition and publish removed?

Why is state transition and publish removed?