leahi-common

Clone Tools

Stats

Commits this week: 29
Total Committers: 20
Last Commit: 10:04
Commits this week: 29

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 min ago

Sean Nash

Does this command cause DD to transition to standby? It looks like the command to give when we transition into post treatment mode to tell DD to transition to post-gen dialysate mode.

Does this command cause DD to transition to standby? It looks like the command to give when we transition into post treatment mode to tell DD to transition to post-gen dialysate mode.

2 mins ago

Sean Nash

Switch not needed here. Just signal standby mode with the received selection.

Switch not needed here. Just signal standby mode with the received selection.

4 mins ago

Sean Nash

Should be disinfection selection type, not command type. Also, move this down into if statement scope.

Should be disinfection selection type, not command type.
Also, move this down into if statement scope.

5 mins ago

Sean Nash

Why are we signaling a command to standby mode? We should signal the selection that we received from UI. Standby mode (later when we get there) will then look at the selection and decide there whic...

Why are we signaling a command to standby mode? We should signal the selection that we received from UI. Standby mode (later when we get there) will then look at the selection and decide there which command to send to DD.

8 mins ago

Sean Nash

Remove blank line.

Remove blank line.

10 mins ago

Sean Nash

Won't this happen when we transition to auto-eject state? Why do it here?

Won't this happen when we transition to auto-eject state? Why do it here?

11 mins ago

Sean Nash

Shouldn't auto-eject state handle this BP homing?

Shouldn't auto-eject state handle this BP homing?

11 mins ago

Sean Nash

Why are we worried about "handled"? Once confirmed, should we just go to auto eject state?

Why are we worried about "handled"? Once confirmed, should we just go to auto eject state?

12 mins ago

Sean Nash

Why is this if statement separated from the one above? Why not just do this stuff in that if statement?

Why is this if statement separated from the one above? Why not just do this stuff in that if statement?

15 mins ago

Sean Nash

There should be function(s) in DDInterface to tell DD what we want (bypass, Qd, etc...).

There should be function(s) in DDInterface to tell DD what we want (bypass, Qd, etc...).

17 mins ago

Sean Nash

This publish code should be in a publish function and we just call that function here.

This publish code should be in a publish function and we just call that function here.

18 mins ago

Sean Nash

Add comment to right.

Add comment to right.

19 mins ago

Sean Nash

Why is this above the definitions banner?

Why is this above the definitions banner?

19 mins ago

Sean Nash

This signal function looks like a message handler. If so, it should take a message (like handlers below) and get the option from the message payload.

This signal function looks like a message handler. If so, it should take a message (like handlers below) and get the option from the message payload.

21 mins ago

Sean Nash

Needs comment to right.

Needs comment to right.

22 mins ago

Sean Nash

Is TD going to request active cooling or is it going to happen automatically after heat or heat+citric disinfection completes? You have an enum of heat disinfection commands, so why do we need sepa...

Is TD going to request active cooling or is it going to happen automatically after heat or heat+citric disinfection completes?
You have an enum of heat disinfection commands, so why do we need separate messages for each disinfection? Should just be 1 message to start a disinfection with a command enum as its payload.

3 hrs ago

Sean Nash

Add TODO to restore later. Why did this need to be commented out?

Add TODO to restore later. Why did this need to be commented out?

3 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

3 hrs ago

Sean Nash

Restore before merging.

Restore before merging.

4 hrs ago

Sean Nash

Add blank line between declarations and code.

Add blank line between declarations and code.

4 hrs ago

Sean Nash

Fix indenting.

Fix indenting.

4 hrs ago

Sean Nash

Fix indenting. It's too deep.

Fix indenting. It's too deep.

4 hrs ago

Sean Nash

Fix indent.

Fix indent.

4 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

4 hrs ago

Sean Nash

Fix indent.

Fix indent.

4 hrs ago

Sean Nash

Fix indent.

Fix indent.

4 hrs ago

Sean Nash

Fix indent.

Fix indent.

5 hrs ago

Sean Nash

Give each alarm its own line.

Give each alarm its own line.

5 hrs ago

Sean Nash

Add doxygen comment to right.

Add doxygen comment to right.

5 hrs ago

Sean Nash

Add blank line between includes and group header.

Add blank line between includes and group header.