td-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 7
Total Committers: 13
Last Commit: 19 Aug
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 min ago

Sean Nash

Shouldn't this be UI REQUEST message? Why would we need to receive/handle a message that we send?

Shouldn't this be UI REQUEST message? Why would we need to receive/handle a message that we send?

7 mins ago

Sean Nash

Do we need to send UI a response? Accept/reject?

Do we need to send UI a response? Accept/reject?

8 mins ago

Sean Nash

Is this a message handler? If so, parameter should be a message and option should be extracted from message payload.

Is this a message handler? If so, parameter should be a message and option should be extracted from message payload.

9 mins ago

Sean Nash

Does this command cause DD to transition to standby? It looks like the command to give when we transition into post treatment mode to tell DD to transition to post-gen dialysate mode.

Does this command cause DD to transition to standby? It looks like the command to give when we transition into post treatment mode to tell DD to transition to post-gen dialysate mode.

10 mins ago

Sean Nash

Switch not needed here. Just signal standby mode with the received selection.

Switch not needed here. Just signal standby mode with the received selection.

13 mins ago

Sean Nash

Should be disinfection selection type, not command type. Also, move this down into if statement scope.

Should be disinfection selection type, not command type.
Also, move this down into if statement scope.

14 mins ago

Sean Nash

Why are we signaling a command to standby mode? We should signal the selection that we received from UI. Standby mode (later when we get there) will then look at the selection and decide there whic...

Why are we signaling a command to standby mode? We should signal the selection that we received from UI. Standby mode (later when we get there) will then look at the selection and decide there which command to send to DD.

17 mins ago

Sean Nash

Remove blank line.

Remove blank line.

19 mins ago

Sean Nash

Won't this happen when we transition to auto-eject state? Why do it here?

Won't this happen when we transition to auto-eject state? Why do it here?

20 mins ago

Sean Nash

Shouldn't auto-eject state handle this BP homing?

Shouldn't auto-eject state handle this BP homing?

20 mins ago

Sean Nash

Why are we worried about "handled"? Once confirmed, should we just go to auto eject state?

Why are we worried about "handled"? Once confirmed, should we just go to auto eject state?

21 mins ago

Sean Nash

Why is this if statement separated from the one above? Why not just do this stuff in that if statement?

Why is this if statement separated from the one above? Why not just do this stuff in that if statement?

24 mins ago

Sean Nash

There should be function(s) in DDInterface to tell DD what we want (bypass, Qd, etc...).

There should be function(s) in DDInterface to tell DD what we want (bypass, Qd, etc...).

26 mins ago

Sean Nash

This publish code should be in a publish function and we just call that function here.

This publish code should be in a publish function and we just call that function here.

27 mins ago

Sean Nash

Add comment to right.

Add comment to right.

28 mins ago

Sean Nash

Why is this above the definitions banner?

Why is this above the definitions banner?

28 mins ago

Sean Nash

This signal function looks like a message handler. If so, it should take a message (like handlers below) and get the option from the message payload.

This signal function looks like a message handler. If so, it should take a message (like handlers below) and get the option from the message payload.

30 mins ago

Sean Nash

Needs comment to right.

Needs comment to right.

30 mins ago

Sean Nash

Is TD going to request active cooling or is it going to happen automatically after heat or heat+citric disinfection completes? You have an enum of heat disinfection commands, so why do we need sepa...

Is TD going to request active cooling or is it going to happen automatically after heat or heat+citric disinfection completes?
You have an enum of heat disinfection commands, so why do we need separate messages for each disinfection? Should just be 1 message to start a disinfection with a command enum as its payload.

3 hrs ago

Sean Nash

This is already in staging. Is this branch obsolete?

This is already in staging. Is this branch obsolete?

5 hrs ago

Sean Nash

Why are we commenting this out?

Why are we commenting this out?

5 hrs ago

Sean Nash

Magic number. Make a #define. Should this command be sent here or in transition function of pre-tx mode?

Magic number. Make a #define.
Should this command be sent here or in transition function of pre-tx mode?

6 hrs ago

Vendor - TEL - Varshini Nagabooshanam

6 hrs ago

Sean Nash

Why are we ending air trap control here?

Why are we ending air trap control here?

6 hrs ago

Sean Nash

Why is this commented out?

Why is this commented out?

7 hrs ago

Sean Nash

Add one more blank line before test support banner.

Add one more blank line before test support banner.

7 hrs ago

Sean Nash

Remove these blank lines.

Remove these blank lines.

Wednesday 19 Aug
4:38 pm

Michael Garthwaite and Sean Nash

2:33 pm

Sean Nash

Doesn't look fixed. 717 and 732 are swapped (and so out of order). This array should be in order by rank.

Doesn't look fixed. 717 and 732 are swapped (and so out of order). This array should be in order by rank.

2:20 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed