leahi-dialin / leahi_dialin / fp

modules

Clone Tools

Stats

Commits this week: 3
Total Committers: 7
Last Commit: 20 Aug
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 20 Aug
4:31 pm

Zoltan Miskolci

Valve fixes

Options
    • -8
    • +8
    ./valves.py
  2. … 1 more file in changeset.
4:17 pm

Dara Navaei

LEAHI-DIALIN-LDT-5630_Fix valve broadcast handling
LEAHI-DIALIN-LDT-5630_Fix valve broadcast handling
2:16 pm

Zoltan Miskolci

1:40 pm

Michael Garthwaite

10:53 am

Zoltan Miskolci

9:36 am

Zoltan Miskolci

No, it won't cause an error. The execute() function checks for the leahi-common folder existence first, if it does not exists, it returns, skipping the whole update process. Not everyone have acces...

No, it won't cause an error. The execute() function checks for the leahi-common folder existence first, if it does not exists, it returns, skipping the whole update process.
Not everyone have access to that folder and a whl file don't need to run the update every time, it's more like for those who develop the code.

Also if it's not at the very beginning, the enums will be processed in the next imports, and updating them afterwards is meaningless as it won't reflect in the running code. The files needs to be updated before any other object tries to call them to make an instance.

Wednesday 19 Aug
10:34 pm

Michael Garthwaite

This will be called when a user imports leahi-dialin, right? ( import leahi-dialin ) and thus cause a traceback cause the user wont have the path to the header files required for this execute call....

This will be called when a user imports leahi-dialin, right? ( import leahi-dialin ) and thus cause a traceback cause the user wont have the path to the header files required for this execute call.

suggest keeping the call in if _name_ == '_main_': of enum_update and running that

10:26 pm

Michael Garthwaite

Tuesday 18 Aug
11:45 am

Raghu Kallala

11:24 am

Dara Navaei

LEAHI-DIALIN-LDT-5615_[Dialin] Update Priming related data for auto-priming service
LEAHI-DIALIN-LDT-5615_[Dialin] Update Priming related data for auto-priming service
Thursday 13 Aug
1:21 pm

Raghu Kallala

12:37 pm

Zoltan Miskolci

- Added new enums - Renamed some members - Added missing _str_lists - Adjusted code for renaming

Options
    • -7
    • +7
    ./events.py
    • -1
    • +1
    ./levels.py
    • -1
    • +1
    ./ro_pump.py
    • -8
    • +8
    ./valves.py
  5. … 8 more files in changeset.
10:42 am

Zoltan Miskolci

We will need to get the event_id first, to know how to process the content as Operation status content is different from rest. So this line is just for getting the event id, and based on the resul...

We will need to get the event_id first, to know how to process the content as Operation status content is different from rest.

So this line is just for getting the event id, and based on the result, process the rest into the correct variables

10:40 am

Zoltan Miskolci

removed

removed

10:37 am

Zoltan Miskolci

fixed

fixed

10:05 am

Raghu Kallala

remove if we are sure about the message ID

remove if we are sure about the message ID

10:02 am

Raghu Kallala

Will we need this after adding the below code?

Will we need this after adding the below code?

9:57 am

Raghu Kallala

Fix typo

Fix typo

Wednesday 12 Aug
5:40 pm

Zoltan Miskolci

fixed operation status event processing

Options
    • -3
    • +16
    ./events.py
  2. … 2 more files in changeset.
1:29 pm

Dara Navaei

LEAHI-DIALIN-LDT-5482_[Dry Self Test] Update the module to match the current dev changes
LEAHI-DIALIN-LDT-5482_[Dry Self Test] Update the module to match the current dev changes
Tuesday 11 Aug
2:59 pm

Dara Navaei

LEAHI-DIALIN-LDT-5205_[DD] Update NVM records architecture in Dialin
LEAHI-DIALIN-LDT-5205_[DD] Update NVM records architecture in Dialin
11:38 am

Zoltan Miskolci

- Updated DD service and usage info enum - Updated related set requests - Added FP records enums - Added FP records modules

Options
    • -0
    • +218
    ./records.py
    • -0
    • +74
    ./records_get_requests.py
    • -0
    • +96
    ./records_get_responses.py
    • -0
    • +109
    ./records_set_requests.py
    • -0
    • +92
    ./records_set_responses.py
  6. … 7 more files in changeset.
9:34 am

Zoltan Miskolci

9:25 am

Zoltan Miskolci

Merge branch 'LDT-5152-handler_refactor' into staging

Options
    • -141
    • +108
    ./events.py
  2. … 5 more files in changeset.
Monday 10 Aug
3:36 pm

Zoltan Miskolci

I think that's what is usually shown, the first 7 char, but in this case it might have been a typo

I think that's what is usually shown, the first 7 char, but in this case it might have been a typo

3:07 pm

Raghu Kallala

2:29 pm

Raghu Kallala

Was it a regulatory requirement before to have 7 characters from commit ID or something we implemented?

Was it a regulatory requirement before to have 7 characters from commit ID or something we implemented?

Friday 07 Aug
3:49 pm

Zoltan Miskolci

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update. For more ...

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update.

For more information check LDT-5205 CR, file: utils\ enum_updater.py

11:58 am

Zoltan Miskolci

Merge branch 'staging' into LDT-5205-dd_nvm_update

Options
    • -2
    • +51
    ./events.py
  2. … 14 more files in changeset.
11:10 am

Zoltan Miskolci

fixing msg ids and enums

Options
    • -8
    • +17
    ./events.py
  2. … 5 more files in changeset.