leahi-dialin / leahi_dialin / td / modules

air_pump.py

Clone Tools

Stats

Commits this week: 0
Total Committers: 5
Last Commit: 20 Aug
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 20 Aug
2:16 pm

Zoltan Miskolci

1:40 pm

Michael Garthwaite

9:36 am

Zoltan Miskolci

No, it won't cause an error. The execute() function checks for the leahi-common folder existence first, if it does not exists, it returns, skipping the whole update process. Not everyone have acces...

No, it won't cause an error. The execute() function checks for the leahi-common folder existence first, if it does not exists, it returns, skipping the whole update process.
Not everyone have access to that folder and a whl file don't need to run the update every time, it's more like for those who develop the code.

Also if it's not at the very beginning, the enums will be processed in the next imports, and updating them afterwards is meaningless as it won't reflect in the running code. The files needs to be updated before any other object tries to call them to make an instance.

Wednesday 19 Aug
10:34 pm

Michael Garthwaite

This will be called when a user imports leahi-dialin, right? ( import leahi-dialin ) and thus cause a traceback cause the user wont have the path to the header files required for this execute call....

This will be called when a user imports leahi-dialin, right? ( import leahi-dialin ) and thus cause a traceback cause the user wont have the path to the header files required for this execute call.

suggest keeping the call in if _name_ == '_main_': of enum_update and running that

Tuesday 18 Aug
11:45 am

Raghu Kallala

Thursday 13 Aug
10:37 am

Zoltan Miskolci

fixed

fixed

9:57 am

Raghu Kallala

Fix typo

Fix typo

Tuesday 11 Aug
2:59 pm

Dara Navaei

LEAHI-DIALIN-LDT-5205_[DD] Update NVM records architecture in Dialin
LEAHI-DIALIN-LDT-5205_[DD] Update NVM records architecture in Dialin
9:34 am

Zoltan Miskolci

Monday 10 Aug
3:36 pm

Zoltan Miskolci

I think that's what is usually shown, the first 7 char, but in this case it might have been a typo

I think that's what is usually shown, the first 7 char, but in this case it might have been a typo

3:07 pm

Raghu Kallala

2:29 pm

Raghu Kallala

Was it a regulatory requirement before to have 7 characters from commit ID or something we implemented?

Was it a regulatory requirement before to have 7 characters from commit ID or something we implemented?

Friday 07 Aug
3:49 pm

Zoltan Miskolci

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update. For more ...

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update.

For more information check LDT-5205 CR, file: utils\ enum_updater.py

11:58 am

Zoltan Miskolci

Merge branch 'staging' into LDT-5205-dd_nvm_update

Options
    • -0
    • +24
    ./air_pump.py
  2. … 14 more files in changeset.
Thursday 06 Aug
10:21 pm

Michael Garthwaite

10:10 pm

Michael Garthwaite

In FW we pre-populated Alarm IDs up to 300 to help with the reservation process. Would this also benefit dialin if we reserve up to 300?

In FW we pre-populated Alarm IDs up to 300 to help with the reservation process. Would this also benefit dialin if we reserve up to 300?

Wednesday 05 Aug
4:19 pm

Zoltan Miskolci

Merge branch 'staging' into LDT-5152-handler_refactor

Options
    • -0
    • +24
    ./air_pump.py
  2. … 13 more files in changeset.
3:12 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

3:09 pm

Zoltan Miskolci

Merge branch 'LDT-5214-override_air_pump_rpm' into staging

Options
    • -0
    • +24
    ./air_pump.py
  2. … 3 more files in changeset.
8:31 am

Michael Garthwaite

Wednesday 29 Jul
8:13 pm

Vendor - TEL - Suresh Dharnala

5:11 pm

Zoltan Miskolci

Merge branch 'staging' into LDT-5152-handler_refactor

Options
    • -2
    • +0
    ./air_pump.py
  2. … 9 more files in changeset.
5:03 pm

Zoltan Miskolci

4:29 pm

Raghu Kallala

3:33 pm

Zoltan Miskolci

Fixed in all 3 file

Fixed in all 3 file

3:16 pm

Raghu Kallala

same typo

same typo

3:15 pm

Raghu Kallala

typo "the states enum class"

typo "the states enum class"

11:13 am

Zoltan Miskolci

- Updated descriptions - Refactored FP module - Refactored DD module

Options
    • -1
    • +1
    ./air_pump.py
  2. … 43 more files in changeset.
Tuesday 28 Jul
12:02 pm

Dara Navaei

LEAHI-DIALIN-LDT-5214_[FW+Dialin] New override for Air Pump RPM parameter
LEAHI-DIALIN-LDT-5214_[FW+Dialin] New override for Air Pump RPM parameter
Monday 27 Jul
9:26 am

Zoltan Miskolci

Added Air Pump RPM override method and MSG_ID

Options
    • -0
    • +24
    ./air_pump.py
  2. … 1 more file in changeset.