Activity leahi-dialin/leahi_dialin/td/modules/records_get

2:16 pm

Michael Garthwaite

More
LEAHI-DIALIN-LDT-5205-2
finished reviewing

9:36 am

No, it won't cause an error. The execute() function checks for the leahi-common folder existence first, if it does not exists, it returns, skipping the whole update process. Not everyone have acces...

No, it won't cause an error. The execute() function checks for the leahi-common folder existence first, if it does not exists, it returns, skipping the whole update process.
Not everyone have access to that folder and a whl file don't need to run the update every time, it's more like for those who develop the code.

Also if it's not at the very beginning, the enums will be processed in the next imports, and updating them afterwards is meaningless as it won't reflect in the running code. The files needs to be updated before any other object tries to call them to make an instance.

10:34 pm

Michael Garthwaite

More
Re: LEAHI-DIALIN-LDT-5205-2
commented on review

This will be called when a user imports leahi-dialin, right? ( import leahi-dialin ) and thus cause a traceback cause the user wont have the path to the header files required for this execute call....

This will be called when a user imports leahi-dialin, right? ( import leahi-dialin ) and thus cause a traceback cause the user wont have the path to the header files required for this execute call.

suggest keeping the call in if _name_ == '_main_': of enum_update and running that

11:45 am