Activity leahi-dialin/leahi

2:16 pm

Zoltan Miskolci

More
9a2c277
changed 10 files
LDT-5615-priming, LDT-5630-fix_valves and 2 more LEAHI-DIALIN-LDT-5615-1

Merge branch 'LDT-5205-dd_nvm_update' into staging

- -3
- +6
./modules/alarms.py
- History
- Source
- Diff
./modules/alarms.py
- -1
- +1
./modules/syringe_pump.py
- History
- Source
- Diff
./modules/syringe_pump.py
- -6
- +7
./proxies/ui_proxy.py
- History
- Source
- Diff
./proxies/ui_proxy.py
… 7 more files in changeset.

1:40 pm

Michael Garthwaite

More
LEAHI-DIALIN-LDT-5205-2
finished reviewing

10:53 am

No, it won't cause an error. The execute() function checks for the leahi-common folder existence first, if it does not exists, it returns, skipping the whole update process. Not everyone have acces...

No, it won't cause an error. The execute() function checks for the leahi-common folder existence first, if it does not exists, it returns, skipping the whole update process.
Not everyone have access to that folder and a whl file don't need to run the update every time, it's more like for those who develop the code.

Also if it's not at the very beginning, the enums will be processed in the next imports, and updating them afterwards is meaningless as it won't reflect in the running code. The files needs to be updated before any other object tries to call them to make an instance.

10:34 pm

Michael Garthwaite

More
Re: LEAHI-DIALIN-LDT-5205-2
commented on review

This will be called when a user imports leahi-dialin, right? ( import leahi-dialin ) and thus cause a traceback cause the user wont have the path to the header files required for this execute call....

This will be called when a user imports leahi-dialin, right? ( import leahi-dialin ) and thus cause a traceback cause the user wont have the path to the header files required for this execute call.

suggest keeping the call in if _name_ == '_main_': of enum_update and running that

10:26 pm

Michael Garthwaite

More
LEAHI-DIALIN-LDT-5482-1
finished reviewing

11:45 am

Raghu Kallala

More
LEAHI-DIALIN-LDT-5205-2
finished reviewing

11:24 am

Dara Navaei

More
LEAHI-DIALIN-LDT-5615-1
started review

LEAHI-DIALIN-LDT-5615_[Dialin] Update Priming related data for auto-priming service

1:21 pm

Raghu Kallala

More
LEAHI-DIALIN-LDT-5482-1
finished reviewing

12:37 pm

Zoltan Miskolci

More
d0dedd8
changed 12 files
LDT-5482-dry_self_test_update, LDT-5615-priming and 3 more LEAHI-DIALIN-LDT-5482-1

- Added new enums - Renamed some members - Added missing _str_lists - Adjusted code for renaming

- -1
- +1
./modules/ejector.py
- History
- Source
- Diff
./modules/ejector.py
- -24
- +24
./modules/events.py
- History
- Source
- Diff
./modules/events.py
- -109
- +110
./modules/syringe_pump.py
- History
- Source
- Diff
./modules/syringe_pump.py
… 9 more files in changeset.

10:43 am

Zoltan Miskolci

More
99a9173
changed 1 file
LDT-5482-dry_self_test_update, LDT-5615-priming and 3 more LEAHI-DIALIN-LDT-5482-1

removed commented out line

- -1
- +0
./proxies/ui_proxy.py
- History
- Source
- Diff
./proxies/ui_proxy.py

10:42 am

Zoltan Miskolci

We will need to get the event_id first, to know how to process the content as Operation status content is different from rest. So this line is just for getting the event id, and based on the resul...

We will need to get the event_id first, to know how to process the content as Operation status content is different from rest.

So this line is just for getting the event id, and based on the result, process the rest into the correct variables

10:40 am