leahi-fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Removing it now. will introduce it later if required

Removing it now. will introduce it later if required

will finalize it when ocean spray logic is tested

will finalize it when ocean spray logic is tested

dryBicartState is top level state machine which is different data type. removed dryBicartSubstate

dryBicartState is top level state machine which is different data type. removed dryBicartSubstate

removed

removed

This is not extra blank line its a line for TASK_GENERAL_INTERVAL )

This is not extra blank line its a line for TASK_GENERAL_INTERVAL )

a macro used to create a contiguous bitmask starting at bit position l (low) and ending at bit position h

a macro used to create a contiguous bitmask starting at bit position l (low) and ending at bit position h

nr means short form of bit 'number', unsigned long is portable, 32bit for 32-bit cpu and 64 bits for 64bit cpu whereas unsigned int is always 32 bits regardless of architecture.

nr means short form of bit 'number', unsigned long is portable, 32bit for 32-bit cpu and 64 bits for 64bit cpu whereas unsigned int is always 32 bits regardless of architecture.

Remove this blank line.

Remove this blank line.

Put () around each of the 2 conditions being ANDed.

Put () around each of the 2 conditions being ANDed.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Add a blank line after declarations.

Add a blank line after declarations.

Remove blank line.

Remove blank line.

Should we remove this else if or is it going to be restored later?

Should we remove this else if or is it going to be restored later?

Remove extra blank lines.

Remove extra blank lines.

Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

Why do we need this?

Why do we need this?

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above. What does nr stand for?

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above.
What does nr stand for?

Let's remove this commented line.

Let's remove this commented line.

Add blank line before return.

Add blank line before return.

Add blank line after declarations.

Add blank line after declarations.

Why U32? Why not RECOVER_STATE_T?

Why U32? Why not RECOVER_STATE_T?

Lower case x

Lower case x

Is blood flow in need of a PID controller too?

Is blood flow in need of a PID controller too?

Add blank line after declarations.

Add blank line after declarations.