td-firmware / firmware / App / Services

AlarmMgmtSWFaults.h

Clone Tools

Stats

Commits this week: 2
Total Committers: 4
Last Commit: 04 Sep 24
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 16 Dec
2:55 pm

Dara Navaei

Done.

Done.

2:53 pm

Dara Navaei

No. It is permanent, I would like to know the value for the homing.

No. It is permanent, I would like to know the value for the homing.

2:53 pm

Dara Navaei

I have to make sure the valve is correct before using it.

I have to make sure the valve is correct before using it.

2:17 pm

Sean Nash

The else in this trinary looks wrong - doesn't round up to multiple of 8.

The else in this trinary looks wrong - doesn't round up to multiple of 8.

2:15 pm

Sean Nash

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

2:13 pm

Sean Nash

Declarations should be at top of scope.

Declarations should be at top of scope.

2:13 pm

Sean Nash

Is this temporary?

Is this temporary?

2:12 pm

Sean Nash

2:08 pm

Vendor - TEL - Varshini Nagabooshanam

Updated.

Updated.

2:07 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, we need to

Yes, we need to

2:07 pm

Vendor - TEL - Varshini Nagabooshanam

Deleted.

Deleted.

1:44 pm

Sean Nash

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

1:43 pm

Sean Nash

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

1:36 pm

Sean Nash

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

1:32 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, I deleted.

Yes, I deleted.

1:31 pm

Vendor - TEL - Varshini Nagabooshanam

Deleted.

Deleted.

1:31 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

1:31 pm

Vendor - TEL - Varshini Nagabooshanam

Deleted.

Deleted.

1:01 pm

Dara Navaei

Done

Done

10:21 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:15 am

Sean Nash

MODE_TPAR should be deleted.

MODE_TPAR should be deleted.

10:14 am

Sean Nash

It should no longer be called from OperationModes.c because we are deleted the TxParams mode (delete from enum and any switch statements in OperationModes.c).

It should no longer be called from OperationModes.c because we are deleted the TxParams mode (delete from enum and any switch statements in OperationModes.c).

10:13 am

Sean Nash

ModeTxParams.c/.h are still not deleted. I want you to delete them and commit/push that change. Then I will see both files in RED here in this CR.

ModeTxParams.c/.h are still not deleted. I want you to delete them and commit/push that change. Then I will see both files in RED here in this CR.

Monday 15 Dec
5:00 pm

Vendor - TEL - Varshini Nagabooshanam

Thanks for the clarification. This handler already follows the single-parameter MESSAGE_T *message pattern, and the message ID is already defined and registered in Messaging.c. I’ll keep using the ...

Thanks for the clarification. This handler already follows the single-parameter MESSAGE_T *message pattern, and the message ID is already defined and registered in Messaging.c. I’ll keep using the existing ID, ensure payload length is validated, and parse the param/value from the payload as expected.

4:59 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, this is called in OperationModes.c

Yes, this is called in OperationModes.c

4:58 pm

Vendor - TEL - Varshini Nagabooshanam

Sure.

Sure.

4:58 pm

Vendor - TEL - Varshini Nagabooshanam

Added.

Added.

4:57 pm

Vendor - TEL - Varshini Nagabooshanam

Added.

Added.

2:23 pm

Sean Nash

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

Sunday 14 Dec
7:26 pm

Dara Navaei

Done

Done