Services

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I meant that you should move this function up, not init function down.

I meant that you should move this function up, not init function down.

Change to initDrySelfTests() and move to top (should be first function).

Change to initDrySelfTests() and move to top (should be first function).

prime state not yet implemented. comment this out w/ TODO comment and add an assignemtn to Rx state here for now.

prime state not yet implemented. comment this out w/ TODO comment and add an assignemtn to Rx state here for now.

Why is this commented out?

Why is this commented out?

Remove blank line.

Remove blank line.

Move this transition function call to the transitionToPostTreatmentMode function below.

Move this transition function call to the transitionToPostTreatmentMode function below.

Invalid payload length shouldn't be a reject reason, it should cause a s/w fault (because it suggests the UI and TD software are not compatible versions).

Invalid payload length shouldn't be a reject reason, it should cause a s/w fault (because it suggests the UI and TD software are not compatible versions).

Still not what I had in mind. Let's discuss this.

Still not what I had in mind. Let's discuss this.

We can set bolus volume here now. These functions should be moved to TxParams where all of these settings exist and can be updated.

We can set bolus volume here now. These functions should be moved to TxParams where all of these settings exist and can be updated.

Why does confirm msg have duration again? If UI resends duration, we have to validate it again. If UI just sends confirmation of previously sent duration, we don't have to validate it again.

Why does confirm msg have duration again? If UI resends duration, we have to validate it again. If UI just sends confirmation of previously sent duration, we don't have to validate it again.

These are already in TxParams I believe.

These are already in TxParams I believe.

Should these be moved to Services\TxParams?

Should these be moved to Services\TxParams?

Change 1 to TRUE

Change 1 to TRUE

Agree with name change, but I think BOOL was the correct type. And BOOL is equivalent to U32 anyway so compiler won't care.

Agree with name change, but I think BOOL was the correct type. And BOOL is equivalent to U32 anyway so compiler won't care.

I think these message handlers for editing treatment parameters should be moved to Services\TxParams.

I think these message handlers for editing treatment parameters should be moved to Services\TxParams.

These should probably be moved to Services\TxParams.h because Messaging.c does not use them.

These should probably be moved to Services\TxParams.h because Messaging.c does not use them.

See if we have already defined this stuff in Services\TxParams. TxParams may also have get function(s) for min/max values that you can use.

See if we have already defined this stuff in Services\TxParams. TxParams may also have get function(s) for min/max values that you can use.

Removed

Removed

Removed

Removed

updated

updated

added

added

Added

Added

Removed

Removed

Updated

Updated

Not necessary

Not necessary