td-firmware / firmware / App / Services

AlarmMgmtTD.c

Clone Tools

Stats

Commits this week: 2
Total Committers: 5
Last Commit: 31 Dec 69
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 18 Jun
10:52 am

Vendor - TEL - Arpita Srivastava

mesage payload is not an input. We correctly mentioned it in the param. Input should be none as we are not reading any global or static variable declared at file level.

mesage payload is not an input. We correctly mentioned it in the param.
Input should be none as we are not reading any global or static variable declared at file level.

10:52 am

Vendor - TEL - Arpita Srivastava

Output should be none as we are not updating any global or static variable declared at file level.

Output should be none as we are not updating any global or static variable declared at file level.

10:49 am

Vendor - TEL - Arpita Srivastava

Please convert the function to have only single point of return. You can assign result = FALSE here. Also check for whitespace characters. Use 4 spaces instead of tab.

Please convert the function to have only single point of return.
You can assign result = FALSE here.

Also check for whitespace characters. Use 4 spaces instead of tab.

10:47 am

Vendor - TEL - Arpita Srivastava

Add space : Change all sizeof(ALARM_ID_T) to sizeof( ALARM_ID_T )

Add space : Change all sizeof(ALARM_ID_T) to sizeof( ALARM_ID_T )

10:33 am

Vendor - TEL - Arpita Srivastava

Why are we adding this header here?

Why are we adding this header here?

Wednesday 17 Jun
9:27 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

Monday 15 Jun
3:32 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4160_[Request] Get function for full detailed Alarm Table
LEAHI-TD-FIRMWARE-LDT-4160_[Request] Get function for full detailed Alarm Table
3:25 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

LDT-4160- Added a new functaion to pull the alarm properties

Options
    • -0
    • +33
    ./AlarmMgmtTD.c
  2. … 2 more files in changeset.
2:47 pm

Vendor - TEL - Jashwant Gantyada , Vendor - TEL - Arpita Srivastava and Sean Nash

11:36 am

Vendor - TEL - Arpita Srivastava

Thank you for the clarification!

Thank you for the clarification!

11:33 am

Vendor - TEL - Arpita Srivastava

break into two lines

break into two lines

11:32 am

Vendor - TEL - Arpita Srivastava

Add alarm ALARM_ID_TD_EMPTY_SALINE_BAG

Add alarm ALARM_ID_TD_EMPTY_SALINE_BAG

11:27 am

Vendor - TEL - Arpita Srivastava

Add newAlarmIndicateStop to output

Add newAlarmIndicateStop to output

11:21 am

Vendor - TEL - Arpita Srivastava

Add newAlarmIndicateStop to input and output.

Add newAlarmIndicateStop to input and output.

Friday 12 Jun
11:04 pm

Sean Nash

Arpita, we don't want to use doxygen style comments for function prototypes since we cover functions with the function headers. so this is the proper type of comments.

Arpita, we don't want to use doxygen style comments for function prototypes since we cover functions with the function headers. so this is the proper type of comments.

3:50 pm

Vendor - TEL - Arpita Srivastava

pauseBolusResumeState is input

pauseBolusResumeState is input

3:47 pm

Vendor - TEL - Arpita Srivastava

add alarm

add alarm

3:46 pm

Vendor - TEL - Arpita Srivastava

Replace // to ///< for line 56 to 60

Replace // to ///< for line 56 to 60

3:27 pm

Sean Nash

3:06 pm

Sean Nash

Use // comments for function prototypes.

Use // comments for function prototypes.

3:06 pm

Sean Nash

Either no comment or // comment for function prototypes since doxygen captures function details from function headers.

Either no comment or // comment for function prototypes since doxygen captures function details from function headers.

3:05 pm

Sean Nash

These were fine (and preferred) as // because doxygen gets function details from function headers in the .c file.

These were fine (and preferred) as // because doxygen gets function details from function headers in the .c file.

2:08 pm

Vendor - TEL - Arpita Srivastava

remove this

remove this

2:07 pm

Vendor - TEL - Arpita Srivastava

remove this case

remove this case

2:07 pm

Vendor - TEL - Arpita Srivastava

remove this

remove this

1:42 pm

Vendor - TEL - Arpita Srivastava

remove this

remove this

1:00 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

12:58 pm

Vendor - TEL - Varshini Nagabooshanam

I fixed it but it is not showing in crucible

I fixed it but it is not showing in crucible

12:47 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

12:46 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed