td-firmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 4
Total Committers: 5
Last Commit: 11 Dec
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 16 Dec
2:12 pm

Sean Nash

2:08 pm

Vendor - TEL - Varshini Nagabooshanam

Updated.

Updated.

2:07 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, we need to

Yes, we need to

2:07 pm

Vendor - TEL - Varshini Nagabooshanam

Deleted.

Deleted.

1:44 pm

Sean Nash

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

1:43 pm

Sean Nash

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

I think we should initialize pre-treatment mode here now that we have a pre-treatment mode.

1:36 pm

Sean Nash

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

1:32 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, I deleted.

Yes, I deleted.

1:31 pm

Vendor - TEL - Varshini Nagabooshanam

Deleted.

Deleted.

1:31 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

1:31 pm

Vendor - TEL - Varshini Nagabooshanam

Deleted.

Deleted.

10:21 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:15 am

Sean Nash

MODE_TPAR should be deleted.

MODE_TPAR should be deleted.

10:14 am

Sean Nash

It should no longer be called from OperationModes.c because we are deleted the TxParams mode (delete from enum and any switch statements in OperationModes.c).

It should no longer be called from OperationModes.c because we are deleted the TxParams mode (delete from enum and any switch statements in OperationModes.c).

10:13 am

Sean Nash

ModeTxParams.c/.h are still not deleted. I want you to delete them and commit/push that change. Then I will see both files in RED here in this CR.

ModeTxParams.c/.h are still not deleted. I want you to delete them and commit/push that change. Then I will see both files in RED here in this CR.

Monday 15 Dec
5:00 pm

Vendor - TEL - Varshini Nagabooshanam

Thanks for the clarification. This handler already follows the single-parameter MESSAGE_T *message pattern, and the message ID is already defined and registered in Messaging.c. I’ll keep using the ...

Thanks for the clarification. This handler already follows the single-parameter MESSAGE_T *message pattern, and the message ID is already defined and registered in Messaging.c. I’ll keep using the existing ID, ensure payload length is validated, and parse the param/value from the payload as expected.

4:59 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, this is called in OperationModes.c

Yes, this is called in OperationModes.c

4:58 pm

Vendor - TEL - Varshini Nagabooshanam

Sure.

Sure.

4:58 pm

Vendor - TEL - Varshini Nagabooshanam

Added.

Added.

4:57 pm

Vendor - TEL - Varshini Nagabooshanam

Added.

Added.

Tuesday 09 Dec
9:58 am

Sean Nash

I didn't see this in header file.

I didn't see this in header file.

9:57 am

Sean Nash

I don't see these Lower/Upper Range Limit functions declared in the header file.

I don't see these Lower/Upper Range Limit functions declared in the header file.

9:33 am

Sean Nash

Need to delete this unit (ModeTxParams.c/.h). Also need to remove the mode from the modes enumeration and from OperationModes.c.

Need to delete this unit (ModeTxParams.c/.h). Also need to remove the mode from the modes enumeration and from OperationModes.c.

9:32 am

Sean Nash

I don't think we need this signal function since this is not a mode anymore. Is this function being called somewhere?

I don't think we need this signal function since this is not a mode anymore. Is this function being called somewhere?

Monday 08 Dec
1:11 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

1:11 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

1:11 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

11:17 am

Sean Nash

I don't see an isTreatmentParamInRange function. I think we need to copy from the ModeTxParams.c.

I don't see an isTreatmentParamInRange function. I think we need to copy from the ModeTxParams.c.

11:16 am

Sean Nash

I don't see any get functions. I think we need to copy from ModeTxParams.c. Let's make sure we've copied all needed functions from ModeTxParams.c and then don't forget to delete ModeTxParams.c/.h.

I don't see any get functions. I think we need to copy from ModeTxParams.c.
Let's make sure we've copied all needed functions from ModeTxParams.c and then don't forget to delete ModeTxParams.c/.h.

11:14 am

Sean Nash

Missing return statement.

Missing return statement.