Activity leahi-application/sources/canbus/FrameInterface.cpp

3:06 pm

Stephen Quong and Nicholas Ramirez

More
LEAHI-APPLICATION-LDT-926-1
finished reviewing

2:09 pm

Tiffany Mejia

More
Re: LEAHI-APPLICATION-LDT-926-1
commented on review

Understood, will consider in a future story to adjust all models

1:48 pm

Stephen Quong

More
Re: LEAHI-APPLICATION-LDT-926-1
commented on review

For the models, in their infoText functions, use QStringLiteral when generating the string that is getting returned, if possible. (https://doc.qt.io/archives/qt-5.15/qstring.html#QStringLiteral)

For the models, in their infoText functions, use QStringLiteral when generating the string that is getting returned, if possible.
(https://doc.qt.io/archives/qt-5.15/qstring.html#QStringLiteral)

4:51 pm

Stephen Quong

More
LEAHI-APPLICATION-LDT-926-1
joined review

1:43 pm

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-926-1
commented on review

probably do not need to translate because its a diagnostics page but to keep consistent with all other user facing texts in this file please translate.

10:23 pm

Tiffany Mejia

More
b80f8f8
changed 50 files
LDT-2428-Onboarding-Test-Message-and-Diag-Screen-View, develop and 24 more LEAHI-APPLICATION-LDT-926-1

LDT-931: Main Treatment Screen - SW - Diagnostics Screen-FP - 05: DEV - Feature Implementation

- Add FP Folder structure

- Add The following FP message implementation

Versions

Pressure

Flow

Conductivity

Temperature

Valves

ROPump

BoostPump

Level

-Add FP can channel to Can interpreter

-Implement FP diagnostics screen

- -1
- +1
./FrameInterface.cpp
- History
- Source
- Diff
./FrameInterface.cpp
… 49 more files in changeset.

9:44 pm

Dara Navaei

More
LEAHI-APPLICATION-LDT-926-1
started review

LEAHI-APPLICATION-LDT-926_Feature/Ldt 926 Main Treatment Screen SW 01 Diagnostics Screen FP

1:38 pm

Dara Navaei and Nicholas Ramirez

More
LEAHI-APPLICATION-LDT-450-1
finished reviewing

10:52 am

Tiffany Mejia

More
LEAHI-APPLICATION-LDT-450-1
resumed reviewing

4:09 pm

Behrouz NematiPour

This code is still in the early stage of development, and the debug codes are helpful to keep.

4:08 pm

To ensure that specific components are not referenced anywhere, I do not assign an ID to them. As for the name, however, we'll ensure that it is only added if it needs to be included in the SquishQ...

To ensure that specific components are not referenced anywhere, I do not assign an ID to them.
As for the name, however, we'll ensure that it is only added if it needs to be included in the SquishQt integration test.

4:05 pm