LEAHI-APPLICATION-LDT-450-1 Feature/LDT-450-CreateRx - Application & Dialin

closed on 13 Jun

Author

Moderator

Reviewers

Feature/LDT-450-CreateRx - Application & Dialin

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 78

leahi-application 0
- Folder SDDs 0
  - File CreateRx.puml 0 Remove
- Folder etc/reports/alarms 0
  - File AlarmMapping.csv 0 Remove
  - File AlarmMapping.py 0 Remove
- Folder sources 0
  - Folder bluetooth 0
    - File BluetoothInterface.cpp 0 Remove
  - Folder canbus 0
    - File CanInterface.cpp 0 Remove
    - File FrameInterface.cpp 0 Remove
    - File MessageAcknowModel.cpp 0 Remove
    - File MessageDispatcher.cpp 0 Remove
    - File MessageDispatcher.h 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 3 Remove
  - Folder cloudsync 0
    - File CloudSyncController.cpp 0 Remove
  - Folder device 0
    - File DeviceController.cpp 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File ConfirmTreatmentTable.qml 0 Remove
        
        File MainMenu.qml 0 Remove
        
        File StepIndicator.qml 0 Remove
      - Folder dialogs 0
        
        File DiagnosticsDialog.qml 0 Remove
      - Folder globals 0
        
        File Variables.qml 0 Remove
      - Folder pages 0
        
        Folder disinfect 0
        
        File DisinfectStack.qml 0 Remove
        
        Folder posttreatment 0
        
        File PostTreatmentStack.qml 0 Remove
        
        Folder pretreatment/create 0
        
        File PreTreatmentCreate.qml 0 Remove
        
        File PreTreatmentCreateStack.qml 0 Remove
        
        Folder settings 0
        
        File SettingsDeviceRegistration.qml 3 Remove
        
        File SettingsExportLogs.qml 0 Remove
        
        File SettingsServicePassword.qml 0 Remove
        
        File SettingsStack.qml 0 Remove
        
        Folder treatment 0
        
        File TreatmentStack.qml 0 Remove
        
        File MainStack.qml 0 Remove
        
        File TreatmentFlowBase.qml 0 Remove
      - Folder plugins/virtualkeyboard/styles/denali 0
        
        File style.qml 0 Remove
      - File AlarmItem.qml 0 Remove
      - File KeyboardItem.qml 3 Remove
      - File main.qml 3 Remove
    - File GuiController.cpp 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 0 Remove
  - Folder model 0
    - Folder dg/adjustment/settings 0
      - File MAdjustDGRequests.h 0 Remove
      - File MDuetRoWaterDG.h 0 Remove
    - Folder hd 0
      - Folder adjustment 0
        
        Folder disinfect 0
        
        File MDisinfectAdjustModeRequests.h 0 Remove
        
        File MDisinfectAdjustStartRequests.h 0 Remove
        
        Folder posttreatment 0
        
        File MPostTreatmentAdjustRequests.h 0 Remove
        
        Folder pretreatment 0
        
        File MPreTreatmentAdjustInitTreatmentResponse.h 0 Remove
        
        File MPreTreatmentAdjustParametersValidationResponse.cpp 0 Remove
        
        File MPreTreatmentAdjustParametersValidationResponse.h 0 Remove
        
        File MPreTreatmentAdjustRequests.h 0 Remove
        
        Folder treatment 0
        
        File MTreatmentAdjustRequests.h 0 Remove
      - Folder alarm 0
        
        File MAlarmActiveList.h 0 Remove
        
        File MAlarmMapping.cpp 0 Remove
        
        File MAlarmTriggered.h 0 Remove
      - Folder data 0
        
        File MHDAccelerometerData.h 0 Remove
        
        File MHDOperationModeData.cpp 0 Remove
        
        File MHDOperationModeData.h 0 Remove
        
        File MTreatmentRangesData.h 0 Remove
    - Folder td/data 0
      - File MTDOpModeData.cpp 0 Remove
      - File MTDOpModeData.h 0 Remove
    - File MModel.h 0 Remove
  - Folder storage 0
    - File Logger.cpp 0 Remove
    - File StorageGlobals.cpp 0 Remove
  - Folder view 0
    - Folder hd/data 0
      - File VHDOperationModeData.cpp 0 Remove
      - File VHDOperationModeData.h 0 Remove
      - File VTreatmentRanges.cpp 0 Remove
      - File VTreatmentRanges.h 0 Remove
    - Folder settings 0
      - File VBluetooth.h 0 Remove
      - File VDateTime.cpp 0 Remove
      - File VDateTime.h 0 Remove
    - Folder td/data 0
      - File VTDOpModeData.cpp 0 Remove
      - File VTDOpModeData.h 0 Remove
    - File VTreatmentCreate.cpp 0 Remove
    - File VTreatmentCreate.h 0 Remove
    - File VView.h 0 Remove
  - File ApplicationController.cpp 0 Remove
  - File ApplicationController.h 0 Remove
  - File MainTimer.cpp 0 Remove
  - File MainTimer.h 0 Remove
- File leahi.pro 0 Remove
- File leahi.pro.user 0 Remove
leahi-dialin 0
- Folder leahi_dialin/ui 0
  - File td_messaging.py 0 Remove
  - File td_messaging_alarms.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author & Moderator	51m	8	RESOLVED
Sean Nash	Reviewer - 0% reviewed
Michael Garthwaite	Reviewer - 0% reviewed
Dara Navaei	Reviewer - Complete	14m
Tiffany Mejia	Reviewer - 85% reviewed	32m
Daniel Ho	Reviewer - 0% reviewed
Vinayakam Mani	Reviewer - 0% reviewed
jpaguio (deleted user)	Reviewer - 0% reviewed
Nicholas Ramirez	Reviewer - Complete	52m	4	missing id and object name properties
Total		2h 30m	12

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/sources/.../data/MHDOperationModeData.cpp Deleted

Click to load diff

/sources/model/.../data/MHDOperationModeData.h Deleted

Click to load diff

/sources/.../data/VHDOperationModeData.cpp Deleted

Click to load diff

/sources/view/.../data/VHDOperationModeData.h Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-APPLICATION-LDT-450-1

Feature/LDT-450-CreateRx - Application & Dialin

LEAHI-APPLICATION-LDT-450-1 12

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

Feature/LDT-450-CreateRx - Application & Dialin

LEAHI-APPLICATION-LDT-450-1 12

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time