Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
updated

updated

APPROVED.

APPROVED.

RESOLVED. Added another comment regarding the same.

RESOLVED.
Added another comment regarding the same.

Nicholas Ramirez Thanks for the change to the ok and result. *To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the fun...

Nicholas Ramirez
Thanks for the change to the ok and result.

  • To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the function itself has ok as the parameter name.
  • Also move the:
    ; if ( ! ok ) { goto invalid; }
    

    on the "same line" and "aligned" as the evaluating parameter, to keep the code clean.

APPROVED

APPROVED

updated

updated

updated

updated

updated

updated

remove the ok and just check result and if any fails goto invalid

remove the ok and just check result and if any fails goto invalid

see if you can use payloadLen from MessageGlobals.h

see if you can use payloadLen from MessageGlobals.h

double check

double check

bn aproves

bn aproves

removedin https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-5331-1CFR-87504

removedin https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-5331-1CFR-87504

added checks for this and the one in VSettings

added checks for this and the one in VSettings

remove from prime // priming - TODO check if needed. may not need

remove from prime // priming - TODO check if needed. may not need

check for any null index

check for any null index

BN approves

BN approves

BN approves

BN approves

BN approves

BN approves