leahi-application / sources / canbus

MessageDispatcher.cpp

Clone Tools

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 31 Dec 69
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 19 Aug
1:51 pm

Nicholas Ramirez

updated

updated

12:49 pm

Behrouz NematiPour

APPROVED.

APPROVED.

12:49 pm

Behrouz NematiPour

RESOLVED. Added another comment regarding the same.

RESOLVED.
Added another comment regarding the same.

12:48 pm

Behrouz NematiPour

Nicholas Ramirez Thanks for the change to the ok and result. *To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the fun...

Nicholas Ramirez
Thanks for the change to the ok and result.

  • To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the function itself has ok as the parameter name.
  • Also move the: 
    ; if ( ! ok ) { goto invalid; }

    on the "same line" and "aligned" as the evaluating parameter, to keep the code clean.

12:40 pm

Behrouz NematiPour

APPROVED

APPROVED

Tuesday 18 Aug
4:24 pm

Nicholas Ramirez

updated

updated

4:24 pm

Nicholas Ramirez

updated

updated

4:24 pm

Nicholas Ramirez

updated

updated

3:35 pm

Nicholas Ramirez

remove the ok and just check result and if any fails goto invalid

remove the ok and just check result and if any fails goto invalid

3:34 pm

Nicholas Ramirez

see if you can use payloadLen from MessageGlobals.h

see if you can use payloadLen from MessageGlobals.h

3:17 pm

Nicholas Ramirez

double check

double check

3:04 pm

Nicholas Ramirez

Monday 17 Aug
5:03 pm

Sean Nash

Friday 14 Aug
10:22 am

Nicholas Ramirez

removedin https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-5331-1CFR-87504

removedin https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-5331-1CFR-87504

Wednesday 12 Aug
4:57 pm

Behrouz NematiPour

Tuesday 11 Aug
4:53 pm

Nicholas Ramirez

remove from prime // priming - TODO check if needed. may not need

remove from prime // priming - TODO check if needed. may not need

4:20 pm

Stephen Quong

3:54 pm

Nicholas Ramirez

BN approves

BN approves

3:53 pm

Nicholas Ramirez

BN approves

BN approves

3:52 pm

Nicholas Ramirez

BN approves

BN approves

3:51 pm

Nicholas Ramirez

BN approves

BN approves

Friday 07 Aug
9:53 am

Nicholas Ramirez

updated

updated

9:53 am

Nicholas Ramirez

combined files

combined files

9:53 am

Nicholas Ramirez

fixed

fixed

9:53 am

Nicholas Ramirez

updated

updated

8:54 am

Nicholas Ramirez

8:53 am

Nicholas Ramirez

Thursday 06 Aug
5:07 pm

Stephen Quong and Behrouz NematiPour

4:08 pm

Stephen Quong and Behrouz NematiPour

4:07 pm

Nicholas Ramirez