Activity leahi-application/sources/model

Tree
Accordion

Stats

Commits this week: 8

Total Committers:	6
Last Commit:	31 Dec 69
Commits this week:	8

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Today

6 hrs ago

Nicholas Ramirez

More
0404b2d
changed 23 files
feature/LDT-5586-Heat-Disinfect LEAHI-APPLICATION-LDT-5586-1

LDT-5589 Disinfection - SW - 01- Heat Disinfect - R&I - 03: DEV - Feature Implementation & Code Document [& Diagnostics]

update message id and remove obsoelte disinfect items

- -11
- +0
./MModel.h
- History
- Source
- Diff
./MModel.h
- -65
- +0
./hd/adjustment/disinfect/MDisinfectAdjustModeRequests.h
- History
- Source
- Diff
./hd/.../MDisinfectAdjustModeRequests.h
- -49
- +0
./hd/adjustment/disinfect/MDisinfectAdjustModeResponse.cpp
- History
- Source
- Diff
./hd/.../MDisinfectAdjustModeResponse.cpp
- -83
- +0
./hd/adjustment/disinfect/MDisinfectAdjustModeResponse.h
- History
- Source
- Diff
./hd/.../MDisinfectAdjustModeResponse.h
- -1
- +1
./hd/adjustment/disinfect/MDisinfectAdjustStartRequests.h
- History
- Source
- Diff
./hd/.../MDisinfectAdjustStartRequests.h
- -2
- +2
./hd/adjustment/disinfect/MDisinfectAdjustStartResponse.h
- History
- Source
- Diff
./hd/.../MDisinfectAdjustStartResponse.h
- -13
- +13
./hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
./hd/alarm/MAlarmMapping.cpp
… 16 more files in changeset.

8 hrs ago

Nicholas Ramirez

bn approves

bn approves

8 hrs ago

Nicholas Ramirez

BN approvo

BN approvo

13 hrs ago

Dara Navaei

More
LEAHI-APPLICATION-LDT-5586-1
started review

LEAHI-APPLICATION-LDT-5586_Disinfection - SW - 01- Heat Disinfect - R&I

LEAHI-APPLICATION-LDT-5586_Disinfection - SW - 01- Heat Disinfect - R&I

14 hrs ago

Dara Navaei

Wednesday 19 Aug

9:24 pm

Dara Navaei , Tiffany Mejia , Stephen Quong and Nicholas Ramirez

More
LEAHI-APPLICATION-LDT-5618-1
finished reviewing

8:07 pm

Behrouz NematiPour

More
LEAHI-APPLICATION-LDT-5618-1
started review

LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C

LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C

8:06 pm

Behrouz NematiPour

More
1244c4e
changed 5 files
LDT-5618-sw-misc-enhc-sw-board-freeze, develop and 5 more LEAHI-APPLICATION-LDT-5618-1

Updated the Alarm Mapping with the staging.

- -16
- +16
./hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
./hd/alarm/MAlarmMapping.cpp
… 4 more files in changeset.

4:21 pm

Behrouz NematiPour

4:07 pm

Behrouz NematiPour

More
582028a
changed 5 files
LDT-5485-sw-misc-enhc---sw---01--asn---iso-uf, LDT-5618-sw-misc-enhc-sw-board-freeze and 6 more LEAHI-APPLICATION-LDT-5618-1

Adding Alarm Mapping, since the automation is now disabled for migrations.

- -24
- +24
./hd/alarm/MAlarmMapping.cpp
- History
- Source
- Diff
./hd/alarm/MAlarmMapping.cpp
… 4 more files in changeset.

3:04 pm

Dara Navaei

More
LEAHI-APPLICATION-LDT-5618-1
started review

LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C

LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C

2:05 pm

Dara Navaei

More
LEAHI-APPLICATION-LDT-5572-1
started review

LEAHI-APPLICATION-LDT-5572_Service - SW - 01- Calibration - Hydraulics - R&I

LEAHI-APPLICATION-LDT-5572_Service - SW - 01- Calibration - Hydraulics - R&I

1:51 pm

Nicholas Ramirez

updated

updated

12:49 pm

Behrouz NematiPour

APPROVED.

APPROVED.

12:49 pm

Behrouz NematiPour

RESOLVED. Added another comment regarding the same.

RESOLVED.
Added another comment regarding the same.

12:48 pm

Behrouz NematiPour

More
Re: LEAHI-APPLICATION-LDT-5158-1
commented on review

Nicholas Ramirez Thanks for the change to the ok and result. *To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the fun...

Nicholas Ramirez
Thanks for the change to the ok and result.

To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the function itself has ok as the parameter name.
Also move the:
```
; if ( ! ok ) { goto invalid; }
```
on the "same line" and "aligned" as the evaluating parameter, to keep the code clean.

12:40 pm

Behrouz NematiPour

APPROVED

APPROVED

12:28 pm

Behrouz NematiPour

12:28 pm

Behrouz NematiPour

More
LEAHI-APPLICATION-LDT-5331-1
finished reviewing

Tuesday 18 Aug

4:24 pm

Nicholas Ramirez

updated

updated

4:24 pm

Nicholas Ramirez

updated

updated

4:24 pm

Nicholas Ramirez

updated

updated

3:50 pm

Nicholas Ramirez

3:50 pm

Stephen Quong

More
LEAHI-APPLICATION-LDT-5331-1
finished reviewing

3:35 pm

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-5158-1
commented on review

remove the ok and just check result and if any fails goto invalid

remove the ok and just check result and if any fails goto invalid

3:34 pm

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-5158-1
commented on review

see if you can use payloadLen from MessageGlobals.h

see if you can use payloadLen from MessageGlobals.h

3:17 pm

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-5158-1
commented on review

double check

double check

3:07 pm

Nicholas Ramirez

bn aproves

bn aproves

3:04 pm

Nicholas Ramirez

Monday 17 Aug

5:03 pm

Sean Nash

More
LEAHI-APPLICATION-LDT-5158-1
left review

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-08-20 23:54 -0700