BubbleDetector.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

When Systems gives me Leahi terms, they will be very small fractions.

When Systems gives me Leahi terms, they will be very small fractions.

Fixed.

Fixed.

You're right. Old comment from Denali. Fixed.

You're right. Old comment from Denali. Fixed.

Came from Denali, so I believe this is what they wanted. The nearly 5 minutes is the one the user sees.

Came from Denali, so I believe this is what they wanted. The nearly 5 minutes is the one the user sees.

space needed in sizeof( BOOL ). Follow the same for line no : 526.

space needed in sizeof( BOOL ). Follow the same for line no : 526.

Please update I/O.

Please update I/O.

Add alarm.

Add alarm.

Please add param.

Please add param.

just 0.0F would work?

just 0.0F would work?

Is it just on/off control or variable speed control?

Is it just on/off control or variable speed control?

Alarm descriptions and trigger conditions calls out "more than 4 minutes" and Instructions says, "nearly 5 minutes". is this intended to display this way?

Alarm descriptions and trigger conditions calls out "more than 4 minutes" and Instructions says, "nearly 5 minutes". is this intended to display this way?

Why?

Why?

Restore bulk of this function for now.

Restore bulk of this function for now.

I am. Didn't want to wait (up to 50ms) for pump to stop if hard stop is requested. So forcing to off immediately. Not how I would ordinarily want to handle this, but in this case I am.

I am. Didn't want to wait (up to 50ms) for pump to stop if hard stop is requested. So forcing to off immediately. Not how I would ordinarily want to handle this, but in this case I am.

Why is this necessary? I would think state machine would already handle this.

Why is this necessary? I would think state machine would already handle this.

TD-LDT-736_General Alarm Requirements TD
TD-LDT-736_General Alarm Requirements TD
Fixed.

Fixed.

h18Status - naming order to be changed. same for H18state as well.

h18Status - naming order to be changed. same for H18state as well.

Fixed.

Fixed.

Good point. Fixed.

Good point. Fixed.

We may need to keep generic name of variable as 'pressure' instead of 'pressure_bar' (since it's no more converting into bar unit).

We may need to keep generic name of variable as 'pressure' instead of 'pressure_bar' (since it's no more converting into bar unit).

Do you want to update the TD and RO FPGA compatiable rev as zero? looks currently FPGA returning them as zero and will fail in init mode - FPGA self test.

Do you want to update the TD and RO FPGA compatiable rev as zero? looks currently FPGA returning them as zero and will fail in init mode - FPGA self test.