DG-RESTART-1 DG-RESTART

closed on 28 Feb 20

Author

Moderator

Reviewers

DG-RESTART

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 114

common 0
- File AlarmDefs.h 0 Remove
dgfirmware 0
- Folder firmware 0
  - Folder .launches 0
    - File DG.launch 0 Remove
  - Folder .settings 0
    - File org.eclipse.core.resources.prefs 0 Remove
  - Folder App 0
    - Folder Controllers 0
      - File AlarmLamp.c 0 Remove
      - File AlarmLamp.h 0 Remove
      - File LoadCell.c 6 Remove
      - File LoadCell.h 0 Remove
      - File SensorProcess.c 12 Remove
      - File SensorProcess.h 6 Remove
    - Folder Drivers 0
      - File CPLD.c 0 Remove
      - File CPLD.h 0 Remove
      - File Comm.c 7 Remove
      - File Comm.h 0 Remove
      - File InternalADC.c 0 Remove
      - File InternalADC.h 0 Remove
      - File SafetyShutdown.c 0 Remove
      - File SafetyShutdown.h 0 Remove
    - Folder Modes 0
      - File ModeDisinfect.c 0 Remove
      - File ModeDisinfect.h 0 Remove
      - File ModeDrain.c 0 Remove
      - File ModeDrain.h 0 Remove
      - File ModeFault.c 0 Remove
      - File ModeFault.h 0 Remove
      - File ModeFill.c 0 Remove
      - File ModeFill.h 0 Remove
      - File ModeFlush.c 0 Remove
      - File ModeFlush.h 0 Remove
      - File ModeInitPOST.c 3 Remove
      - File ModeInitPOST.h 0 Remove
      - File ModePostTreat.c 2 Remove
      - File ModePostTreat.h 0 Remove
      - File ModeService.c 0 Remove
      - File ModeService.h 0 Remove
      - File ModeStandby.c 3 Remove
      - File ModeStandby.h 0 Remove
      - File OperationModes.c 0 Remove
      - File OperationModes.h 0 Remove
    - Folder Services 0
      - File AlarmMgmt.c 0 Remove
      - File AlarmMgmt.h 0 Remove
      - File CommBuffers.c 7 Remove
      - File CommBuffers.h 0 Remove
      - File FPGA.c 3 Remove
      - File FPGA.h 0 Remove
      - File Interrupts.c 5 Remove
      - File Interrupts.h 0 Remove
      - File MsgQueues.c 0 Remove
      - File MsgQueues.h 0 Remove
      - File PIControllers.c 0 Remove
      - File PIControllers.h 0 Remove
      - File SystemComm.c 6 Remove
      - File SystemComm.h 0 Remove
      - File SystemCommMessages.c 6 Remove
      - File SystemCommMessages.h 0 Remove
      - File Timers.c 3 Remove
      - File Timers.h 3 Remove
      - File Utilities.c 3 Remove
      - File Utilities.h 3 Remove
      - File WatchdogMgmt.c 3 Remove
      - File WatchdogMgmt.h 0 Remove
    - Folder Tasks 0
      - File TaskBG.c 0 Remove
      - File TaskBG.h 0 Remove
      - File TaskGeneral.c 0 Remove
      - File TaskGeneral.h 0 Remove
      - File TaskPriority.c 0 Remove
      - File TaskPriority.h 0 Remove
    - File Common.h 3 Remove
    - File DGCommon.h 3 Remove
    - File TestSupport.h 3 Remove
  - Folder Debug 0
    - Folder App 0
      - Folder Contollers 0
        
        File subdir_rules.mk 0 Remove
        
        File subdir_vars.mk 0 Remove
      - Folder Drivers 0
        
        File subdir_rules.mk 0 Remove
        
        File subdir_vars.mk 0 Remove
      - Folder Modes 0
        
        File subdir_rules.mk 0 Remove
        
        File subdir_vars.mk 0 Remove
      - Folder Tasks 0
        
        File subdir_rules.mk 0 Remove
        
        File subdir_vars.mk 0 Remove
    - Folder source 0
      - File subdir_rules.mk 0 Remove
      - File subdir_vars.mk 0 Remove
    - File ccsObjs.opt 0 Remove
    - File makefile 0 Remove
    - File objects.mk 0 Remove
    - File sources.mk 0 Remove
  - Folder include 0
    - File adc.h 0 Remove
    - File can.h 0 Remove
    - File etpwm.h 0 Remove
    - File gio.h 0 Remove
    - File mibspi.h 0 Remove
    - File rti.h 0 Remove
    - File sci.h 0 Remove
    - File sys_core.h 0 Remove
    - File sys_vim.h 0 Remove
  - Folder source 0
    - File adc.c 0 Remove
    - File can.c 0 Remove
    - File etpwm.c 0 Remove
    - File gio.c 0 Remove
    - File mibspi.c 0 Remove
    - File notification.c 0 Remove
    - File pinmux.c 0 Remove
    - File rti.c 0 Remove
    - File sci.c 0 Remove
    - File sys_core.asm 0 Remove
    - File sys_link.cmd 0 Remove
    - File sys_main.c 0 Remove
    - File sys_vim.c 0 Remove
  - File .cproject 0 Remove
  - File .gitignore 0 Remove
  - File DG.dil 0 Remove
  - File DG.hcg 0 Remove
  - File irqDispatch_a.asm 3 Remove
  - File irqDispatch_c.c 3 Remove
- File .gitignore 3 Remove
- File .project 3 Remove
fwcommon 0
- File Common.h 0 Remove
- File TestSupport.h 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
snejatali (deleted user)	Author & Moderator	1h 40m	10	Done.
Sean Nash	Reviewer - Complete	2h 32m	27	Done.
Dara Navaei	Reviewer - 3% reviewed	30m	2	This file was in the wrong directory.
Behrouz NematiPour	Reviewer - 75% reviewed	18m
pmontazemi (deleted user)	Reviewer - Complete	1h 25m	63	RESOLVED IN CODE WALKTHROUGH.
Total		6h 27m	102

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/firmware/Debug/.../Contollers/subdir_rules.mk Deleted

Click to load diff

/firmware/Debug/.../Contollers/subdir_vars.mk Deleted

Click to load diff

/firmware/Debug/.../Drivers/subdir_rules.mk Deleted

Click to load diff

/firmware/Debug/App/Drivers/subdir_vars.mk Deleted

Click to load diff

/firmware/Debug/App/Modes/subdir_rules.mk Deleted

Click to load diff

/firmware/Debug/App/Modes/subdir_vars.mk Deleted

Click to load diff

/firmware/Debug/App/Tasks/subdir_rules.mk Deleted

Click to load diff

/firmware/Debug/App/Tasks/subdir_vars.mk Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DG-RESTART-1

DG-RESTART

DG-RESTART-1 102

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

DG-RESTART

DG-RESTART-1 102

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time