LEAHI-APPLICATION-LDT-1536-1 LEAHI-APPLICATION-LDT-1536_Feature/Ldt 1536 Headerbar Wifi Indicator

closed on 12 Aug

Author

Moderator

Reviewers

LEAHI-APPLICATION-LDT-1536_Feature/Ldt 1536 Headerbar Wifi Indicator

Activity

Details
Objectives
General Comments 3
Unresolved
Resolved
Number of files included: 17

leahi-application 0
- Folder SDDs 0
  - Folder common_puml 0
    - File WiFi_Info.puml 0 Remove
  - File Wifi.puml 0 Remove
  - File Wifi_Popup.png 0 Remove
  - File Wifi_Popup.puml 0 Remove
- Folder sources 0
  - Folder device 0
    - File DeviceController.cpp 12 Remove
    - File DeviceController.h 3 Remove
    - File DeviceView.cpp 0 Remove
    - File DeviceView.h 3 Remove
  - Folder gui/qml 0
    - Folder components 0
      - File HeaderBar.qml 18 Remove
      - File HeaderBarPopup.qml 3 Remove
      - File ModalDialog.qml 6 Remove
    - Folder dialogs 0
      - Folder headerbar 0
        
        File WiFiDialog.qml 0 Remove
      - File WiFiDialog.qml 0 Remove
    - Folder globals 0
      - File Colors.qml 3 Remove
    - Folder pages/settings 0
      - File SettingsWiFi.qml 0 Remove
    - File main.qml 3 Remove
- File leahi.qrc 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Nicholas Ramirez	Author & Moderator	2h 4m	18	updated this to be consistant
Sean Nash	Reviewer - 0% reviewed
Michael Garthwaite	Reviewer - 0% reviewed
Dara Navaei	Reviewer - 0% reviewed	0m
Behrouz NematiPour	Reviewer - Complete	1h 31m	30	RESOLVED
Tiffany Mejia	Reviewer - 0% reviewed
Daniel Ho	Reviewer - 0% reviewed
Vinayakam Mani	Reviewer - 0% reviewed
Stephen Quong	Reviewer - Complete	1h 41m	6	RESOLVED
Total		5h 17m	54

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Stephen Quong

Update SettingsWiFi.qml to not show contents of IP Address field when there i...

Update SettingsWiFi.qml to not show contents of IP Address field when there is a WiFi connection error.

12 Aug

Stephen Quong

Resolved

12 Aug

Nicholas Ramirez

I pushed a fix for this behavior

12 Aug

Stephen Quong

RESOLVED

12 Aug

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-APPLICATION-LDT-1536-1

LEAHI-APPLICATION-LDT-1536_Feature/Ldt 1536 Headerbar Wifi Indicator

LEAHI-APPLICATION-LDT-1536-1 54

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Stephen Quong

Nicholas Ramirez

Stephen Quong

Log time

LEAHI-APPLICATION-LDT-1536_Feature/Ldt 1536 Headerbar Wifi Indicator

LEAHI-APPLICATION-LDT-1536-1 54

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Stephen Quong

Nicholas Ramirez

Stephen Quong

Log time