LEAHI-DIALIN-LEAH-139-3 LEAH-139-dial-dd-base-object

closed on 13 Feb

Author

Moderator

Reviewers

LEAH-139-dial-dd-base-object

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 40

leahi-dialin 0
- Folder leahi-dialin 0
  - Folder dd 0
    - Folder modules 0
      - File __init__.py 0 Remove
      - File concentrate_pump.py 0 Remove
      - File conductivity_sensors.py 0 Remove
      - File dialysate_pump.py 0 Remove
      - File heaters.py 0 Remove
      - File levels.py 0 Remove
      - File pressure_sensors.py 0 Remove
      - File temperature_sensors.py 0 Remove
      - File valves.py 0 Remove
    - Folder proxies 0
      - File __init__.py 0 Remove
      - File td_proxy.py 0 Remove
    - File conductivity_sensors.py 0 Remove
    - File pressure_sensors.py 0 Remove
    - File td_proxy.py 0 Remove
    - File valves.py 0 Remove
  - Folder protocols 0
    - File CAN.py 0 Remove
- Folder leahi_dialin 0
  - Folder common 0
    - File dd_defs.py 0 Remove
    - File msg_ids.py 0 Remove
  - Folder dd 0
    - Folder modules 0
      - File __init__.py 0 Remove
      - File balancing_chamber.py 4 Remove
      - File concentrate_pump.py 28 Remove
      - File conductivity_sensors.py 14 Remove
      - File constants.py 0 Remove
      - File dialysate_pump.py 6 Remove
      - File gen_dialysate.py 9 Remove
      - File heaters.py 14 Remove
      - File levels.py 18 Remove
      - File piston_pump.py 9 Remove
      - File pressure_sensors.py 21 Remove
      - File temperature_sensors.py 14 Remove
      - File valves.py 16 Remove
    - Folder proxies 0
      - File __init__.py 0 Remove
      - File ro_proxy.py 6 Remove
      - File td_proxy.py 3 Remove
    - File conductivity_sensors.py 0 Remove
    - File constants.py 0 Remove
    - File dialysate_delivery.py 0 Remove
    - File pressure_sensors.py 0 Remove
    - File td_proxy.py 0 Remove
    - File valves.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Michael Garthwaite	Author & Moderator	42m	74	Fixed. Thanks!
Sean Nash	Reviewer - Complete	2h 53m	75	Maybe add the word "target" in function name and descript...
jpaguio (deleted user)	Reviewer - 0% reviewed
Tiffany Mejia	Reviewer - Complete	8m
Vinayakam Mani	Reviewer - 64% reviewed	5h 38m	13	DD. replace DG to DD across file.
Dara Navaei	Reviewer - 0% reviewed
Behrouz NematiPour	Reviewer - 0% reviewed
Total		9h 23m	162

Linked issues
- LEAH-139
- LEAH-142

#permalink

Objectives

Merge branch 'LEAH-142-dial-td-base-object' into LEAH-139-dial-dd-base-object
Added directories for dd modules
WIP on LEAH-139-dial-dd-base-object
DD temp and valves. updated CAN channels
Merge branch 'LEAH-142-dial-td-base-object' into LEAH-139-dial-dd-base-object
Updated folder naming. Fixed pathing. Fixed relative importing
DD class should now create.
Updated DD valves
fixed dd levels and pressure sensors.
WIP on develop
added dialysate start stop override cmd
updated levels handler. Fixed pressure sensor counter overrides from floats to ints.
commented out interval checkin until FW implementation.
updated proxy commands for demo. Updated message IDs
fixed circular import reference
WIP on develop
fixed various issues in dd modules
WIP on develop
fixed dd set start stop cmds
fixed concentrate pump handler to be in the correct order.
Balancing chamber module and gen dialysate overrides
moved cmd_td_send_dd_gen_dialysate_request to dd.td_proxy instead of td.dd_proxy
added balancing chamber and gen dialysate classes to base DD object
fixed valve state all not updating
fixed missing valve bits in all valve states
fixed valve all states in dd handler
Updated DD concentrate handler. Updated pressure handler. Updated valve positions
updated dd documentation.
WIP on develop
updated dd valve positioning
WIP on develop
fixed concentrate pump handler
fixed concentrate pump handler
updated start stop to include volume parameter
heaters target temperature override
Updated latest dd changes to branch. Implemented Piston Pumps module.
DD integration
Merge branch 'staging' into LEAH-139-dial-dd-base-object

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/leahi-dialin/.../modules/concentrate_pump.py Deleted

Click to load diff

/leahi-dialin/.../modules/conductivity_sensors.py Deleted

Click to load diff

/leahi-dialin/dd/modules/dialysate_pump.py Deleted

Click to load diff

/leahi-dialin/.../modules/pressure_sensors.py Deleted

Click to load diff

/leahi-dialin/.../modules/temperature_sensors.py Deleted

Click to load diff

/leahi-dialin/dd/conductivity_sensors.py Deleted

Click to load diff

/leahi_dialin/dd/conductivity_sensors.py Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-DIALIN-LEAH-139-3

LEAH-139-dial-dd-base-object

LEAHI-DIALIN-LEAH-139-3 162

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LEAH-139-dial-dd-base-object

LEAHI-DIALIN-LEAH-139-3 162

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time